<div class="__aliyun_email_body_block"><div  style="line-height:1.7;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;"><div  style="clear:both;"><span  style="color:#000000;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:.0px;text-transform:none;white-space:normal;word-spacing:.0px;text-decoration-thickness:initial;text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline;">OK, I get it. </span><span  style="margin:.0px;padding:.0px;border:.0px;outline:.0px;color:#000000;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:.0px;text-transform:none;white-space:normal;word-spacing:.0px;text-decoration-thickness:initial;text-decoration-style:initial;text-decoration-color:initial;">Thanks for your answer.</span></div><div  style="clear:both;"><br /></div><blockquote  style="margin-right:0;margin-top:0;margin-bottom:0;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;"><div  style="clear:both;">------------------------------------------------------------------</div><div  style="clear:both;">发件人：Maxim Dounin <mdounin@mdounin.ru></div><div  style="clear:both;">发送时间：2022年12月5日(星期一) 04:13</div><div  style="clear:both;">收件人：nginx-devel <nginx-devel@nginx.org></div><div  style="clear:both;">主　题：Re: Fixed gzip_disable_degradation defined without NGX_HTTP_DEGRADATION (broken by 3b522d7a5b34).</div><div  style="clear:both;"><br /></div>Hello!<br ><br >On Sat, Dec 03, 2022 at 11:16:44PM +0800, 杜叶飞(淮叶) via nginx-devel wrote:<br ><br >> I think gzip_disable_degradation needs NGX_HTTP_DEGRADATION in order to be consistent with where used. <br >> details: https://hg.nginx.org/nginx/rev/3b522d7a5b34 <https://hg.nginx.org/nginx/rev/3b522d7a5b34 ><br ><br >The revision you've linked explains why this "#if" is not really <br >needed even if we are concerned about saving these two bits in the <br >location configuration structure (and we aren't really concerned <br >anyway).<br ><br >Further, the patch you've suggested breaks binary compatibility <br >between nginx builds with and without the degradation module <br >without restoring appropriate flag in the binary signature.  This <br >is clearly incorrect behaviour which can result in segmentation <br >faults or other unexpected behaviour if modules compiled with <br >different assumptions are loaded into nginx.<br ><br >-- <br >Maxim Dounin<br >http://mdounin.ru/<br >_______________________________________________<br >nginx-devel mailing list -- nginx-devel@nginx.org<br >To unsubscribe send an email to nginx-devel-leave@nginx.org<br ></blockquote></div></div>