<html><head><meta http-equiv="content-type" content="text/html; charset=us-ascii"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">Hi,<br><div><br><blockquote type="cite"><div>On 12 Jun 2023, at 23:39, Sergey Kandaurov <pluknet@nginx.com> wrote:</div><br class="Apple-interchange-newline"><div><div># HG changeset patch<br># User Sergey Kandaurov <pluknet@nginx.com><br># Date 1686598736 -14400<br># Mon Jun 12 23:38:56 2023 +0400<br># Node ID a32905d6fc108962a73b4affdb38eba5cc6fd549<br># Parent 262c0178256623c59a54bea81fcf3f92d12d75b6<br>QUIC: fixed rttvar on subsequent RTT samples (ticket #2505).<br><br>Previously, computing rttvar used an updated smoothed_rtt value as per<br>RFC 9002, section 5.3, which appears to be specified in a wrong order.<br>A technical errata ID 7539 is reported.<br><br>diff --git a/src/event/quic/ngx_event_quic_ack.c b/src/event/quic/ngx_event_quic_ack.c<br>--- a/src/event/quic/ngx_event_quic_ack.c<br>+++ b/src/event/quic/ngx_event_quic_ack.c<br>@@ -207,9 +207,9 @@ ngx_quic_rtt_sample(ngx_connection_t *c,<br> adjusted_rtt -= ack_delay;<br> }<br><br>- qc->avg_rtt += (adjusted_rtt >> 3) - (qc->avg_rtt >> 3);<br> rttvar_sample = ngx_abs((ngx_msec_int_t) (qc->avg_rtt - adjusted_rtt));<br> qc->rttvar += (rttvar_sample >> 2) - (qc->rttvar >> 2);<br>+ qc->avg_rtt += (adjusted_rtt >> 3) - (qc->avg_rtt >> 3);<br> }<br><br> ngx_log_debug4(NGX_LOG_DEBUG_EVENT, c->log, 0,<br>_______________________________________________<br>nginx-devel mailing list<br>nginx-devel@nginx.org<br>https://mailman.nginx.org/mailman/listinfo/nginx-devel<br></div></div></blockquote></div><div><br></div><div>LGTM</div><br><div>
<div dir="auto" style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div>----</div><div>Roman Arutyunyan</div><div>arut@nginx.com</div><div><br></div></div><br class="Apple-interchange-newline"><br class="Apple-interchange-newline">
</div>
<br></body></html>