<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
        {font-family:"Cambria Math";
        panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
        {font-family:proximaRegular;
        panose-1:2 11 6 4 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0in;
        font-size:10.0pt;
        font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
        {mso-style-priority:99;
        color:blue;
        text-decoration:underline;}
span.EmailStyle19
        {mso-style-type:personal-reply;
        font-family:"Calibri",sans-serif;
        color:windowtext;}
.MsoChpDefault
        {mso-style-type:export-only;
        font-size:10.0pt;
        mso-ligatures:none;}
@page WordSection1
        {size:8.5in 11.0in;
        margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
        {page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">Thanks for the feedback Yaroslav! Updated patch is attached with the suggested commit log, whitespace, and `rev` changes.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div>
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0" style="border-collapse:collapse">
<tbody>
<tr>
<td style="padding:0in 0in 9.0pt 0in">
<p class="MsoNormal"><a href="https://www.nginx.com/"><b><span style="font-size:10.5pt;font-family:proximaRegular;color:#1D9CD3;text-decoration:none"><img border="0" width="121" height="48" style="width:1.2604in;height:.5in" id="Picture_x0020_1" src="cid:image001.png@01D9DCB2.8EFA5480" alt="signature_3506516580"></span></b></a><b><span style="font-size:10.5pt;font-family:proximaRegular;color:#999999"><o:p></o:p></span></b></p>
</td>
</tr>
<tr>
<td style="padding:0in 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:9.0pt;font-family:"Arial",sans-serif;color:#999999">Ryan Davis</span></b><span style="font-size:8.5pt;font-family:"Arial",sans-serif;color:#999999"> | Sr Software Engineer<o:p></o:p></span></p>
</td>
</tr>
</tbody>
</table>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">nginx-devel <nginx-devel-bounces@nginx.org> on behalf of Yaroslav Zhuravlev <yar@nginx.com><br>
<b>Date: </b>Thursday, August 31, 2023 at 5:26 PM<br>
<b>To: </b>nginx-devel@nginx.org <nginx-devel@nginx.org><br>
<b>Subject: </b>Re: [PATCH] Minor docs fixes<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt">EXTERNAL MAIL: nginx-devel-bounces@nginx.org<br>
<br>
Hi, <br>
<br>
> On 31 Aug 2023, at 21:43, Sergey A. Osokin <osa@freebsd.org.ru> wrote:<br>
> <br>
> Hi,<br>
> <br>
> here's the patch from Ryan.<br>
> <br>
> On Thu, Aug 31, 2023 at 08:31:34PM +0000, Ryan Davis via nginx-devel wrote:<br>
>> Apologies, the corporate SMTP server is doing something unexpected.<br>
> <br>
> # HG changeset patch<br>
> # User Ryan Davis <ry.davis@f5.com><br>
> # Date 1693509279 14400<br>
> #      Thu Aug 31 15:14:39 2023 -0400<br>
> # Node ID 31eebaba6f8d4973c35c40f3da69c9d9fe598438<br>
> # Parent  4e25281328fa2152cadedc52e05f8a1b1bf531cd<br>
> Minor docs fixes<br>
<br>
Perhaps a more descriptive commit log would be better, e.g. <br>
"Fixed lang attribute, added module closing tag."<br>
<br>
> <br>
> - add a missing close tag that tripped up non-streaming XML parsers<br>
> - fix a misclassified `lang` attribute<br>
> <br>
> diff -r 4e25281328fa -r 31eebaba6f8d xml/en/docs/http/ngx_http_api_module_head.xml<br>
> --- a/xml/en/docs/http/ngx_http_api_module_head.xml Tue Aug 29 09:11:57 2023 +0100<br>
> +++ b/xml/en/docs/http/ngx_http_api_module_head.xml Thu Aug 31 15:14:39 2023 -0400<br>
> @@ -9,7 +9,7 @@<br>
> <module name="Module ngx_http_api_module"<br>
>         link="/en/docs/http/ngx_http_api_module.html"<br>
>         lang="en"<br>
> -        rev="3"><br>
> +        rev="4"><br>
> <br>
> <section id="summary"><br>
> <br>
> @@ -298,3 +298,4 @@<br>
> </para><br>
> <br>
> </section><br>
<br>
Blank line missing between section and module tags.<br>
<br>
> +</module><br>
> diff -r 4e25281328fa -r 31eebaba6f8d xml/ru/docs/http/ngx_http_v3_module.xml<br>
> --- a/xml/ru/docs/http/ngx_http_v3_module.xml Tue Aug 29 09:11:57 2023 +0100<br>
> +++ b/xml/ru/docs/http/ngx_http_v3_module.xml Thu Aug 31 15:14:39 2023 -0400<br>
> @@ -8,8 +8,8 @@<br>
> <br>
> <module name="Модуль ngx_http_v3_module"<br>
>         link="/ru/docs/http/ngx_http_v3_module.html"<br>
> -        lang="en"<br>
> -        rev="2"><br>
> +        lang="ru"<br>
> +        rev="3"><br>
<br>
Version bump should also be applied to the En version as well as they correspond to each other.<br>
Or it might be better not to bump the version at all here as the change is small and not content related.<br>
<br>
> <br>
> <section id="summary"><br>
> <br>
> <br>
> -- <br>
> Sergey A. Osokin<br>
> _______________________________________________<br>
> nginx-devel mailing list<br>
> nginx-devel@nginx.org<br>
> <a href="https://mailman.nginx.org/mailman/listinfo/nginx-devel">https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmailman.nginx.org%2Fmailman%2Flistinfo%2Fnginx-devel&data=05%7C01%7Cry.davis%40f5.com%7C1b07ff05f87e41444cac08dbaa68e1d2%7Cdd3dfd2f6a3b40d19be0bf8327d81c50%7C0%7C0%7C638291139671112762%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=AriByeciwGYwHqdfP36a5yoaicPkQlule1QoFF9iugk%3D&reserved=0</a><br>
_______________________________________________<br>
nginx-devel mailing list<br>
nginx-devel@nginx.org<br>
<a href="https://mailman.nginx.org/mailman/listinfo/nginx-devel">https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmailman.nginx.org%2Fmailman%2Flistinfo%2Fnginx-devel&data=05%7C01%7Cry.davis%40f5.com%7C1b07ff05f87e41444cac08dbaa68e1d2%7Cdd3dfd2f6a3b40d19be0bf8327d81c50%7C0%7C0%7C638291139671112762%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=AriByeciwGYwHqdfP36a5yoaicPkQlule1QoFF9iugk%3D&reserved=0</a><o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>