bmaurer at andrew.cmu.edu
Wed Jan 9 08:32:21 MSK 2008
Igor Sysoev wrote:
> On Tue, Jan 08, 2008 at 01:09:55PM -0500, Ben Maurer wrote:
>> Igor Sysoev wrote:
>>> Changes with nginx 0.6.25 08 Jan
>>> *) Bugfix: socket leak in HTTPS mode if deferred accept was used.
>>> Thanks to Ben Maurer.
>> I don't think the patch that's in 0.6.25 actually fixes the deferred
>> accept issue. That issue caused the MSG_PEEK recv to return an EAGAIN
>> which resulted in read and write events not being handled on that
>> socket. The patch currently in the tree only fixes the issue where the
>> user completes the first half of the handshake but then stops responding.
> Yes, you are right. The attached patch should fix this case.
>> Also, is there any reason this isn't merged into 0.5.x?
> It will be merged after some time (about month).
If I remember correctly, according to netstat there were FDs that had
elements in the receive queue. This would suggest that more needs to be
done than to add a timeout (because these sockets had user data on them,
and thus should be added to the epoll)
More information about the nginx