find bug in dns resovle

Robert Gabriel lists at ruby-forum.com
Wed Nov 19 00:43:32 MSK 2008


Igor Sysoev wrote:
> On Mon, Nov 17, 2008 at 10:20:34AM +0800, nginx at aqcx.com wrote:
> 
>>    in function ngx_resolver_copy ,n = (n & 0x3f << 8) + *p;
>>   should be n = ((n & 0x3f) << 8) + *p;otherwis ,& oprator will not work correctlly.
> 
> Thank you very much.
> I had missed it as it becomes apparent on big (>256 bytes) DNS 
> responses.
> What is your full name to include in CHANGES log ?

Isnt the same idea of
n = (n & 0x3f << 8) + *src;

should this be:

n = ((n & 0x3f << 8) + *src);

Sorry I might be wrong... but who knows :P
-- 
Posted via http://www.ruby-forum.com/.





More information about the nginx mailing list