Issue with 3rd-party memc and eval modules

Valery Kholodkov valery+nginxen at grid.net.ru
Wed Feb 17 15:09:47 MSK 2010


----- Markus Jelsma <markus at buyways.nl> wrote:
> Sounds good!
> 
> 
> But Valery, i previously used your new eval module that allows for multiple 
> blocks. That version had an issue with not letting memc_pass close the 
> memcached connection when setting values (getting values worked properly).
> 
> Now, for the moment, i use agentzh's eval which for some reason also allows 
> for multiple eval blocks and does let memc_pass close the connection.
> 
> I'd prefer to use your release if a fix could be made that closes the 
> connection with the memcache server.

I'll try to fix this problem.

> 
> 
> Regards,
> 
> 
> 
> 
> >I appreciate your interest in my software, but the problem with this
> > contributed code at the moment is that it is not as efficient as it could
> > possibly be and it is not universal enough.
> >
> >In particular I don't like the presence of "eval_subrequest_in_memory"
> > directive at all, because it specifies which way of internal communication
> > the module needs to use, which doesn't make any sense for end user.
> >
> >Second, the contributed code allocates a buffer and uses it in order to
> > assemble the output of subrequest in it. This allocation can be totally
> > avoided, if an appropriate state machine is implemented.
> >
> >As soon as these issues are resolved, I'll accept this code.
> 
> Markus Jelsma - Technisch Architect - Buyways BV
> http://www.linkedin.com/in/markus17
> 050-8536620 / 06-50258350
> 
> 
> _______________________________________________
> nginx mailing list
> nginx at nginx.org
> http://nginx.org/mailman/listinfo/nginx

-- 
-- 
Regards,
Valery Kholodkov



More information about the nginx mailing list