ngx unescape uri bug

Maxim Dounin mdounin at
Mon Mar 25 11:46:45 UTC 2013


On Mon, Mar 25, 2013 at 03:11:10PM +0800, David Shee wrote:

> I'm Zuwen Shi from China,I find a unescape uri bug in your program.
> The source code location is src\core\ngx_string.c->ngx_unescape_uri
> If I put a string "%%s%elect",it convert the string to "%slect",and %% to
> %,%el to l,actually the right convert is "%%s%elect".

I would rather say that behaviour is undefined in case of 
incorrect input, and both results are correct.

> So,I patch the ngx_unescape_uri like below,the red part is which I modified.

You may want to post unified diff into nginx-devel@ mailing list.  
And please don't use html.  Thank you.

Maxim Dounin

More information about the nginx mailing list