<div dir="ltr"><div class="gmail_default" style="font-size:small;color:rgb(51,51,153)">Hello,<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Aug 18, 2013 at 3:14 PM, Maxim Dounin <span dir="ltr"><<a href="mailto:mdounin@mdounin.ru" target="_blank">mdounin@mdounin.ru</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>
<br>
</div>Making any changes to the configuration isn't something<br>
significant: even without changes at all new binary on disk might<br>
not consider an old configuration as a valid e.g. due to some<br>
module not compiled in. And a reload might be required for<br>
various external reasons.<br>
<br>
I don't say it's a normal situation, but it's possible, and<br>
proposed change to init script will prevent init script from<br>
working in such situation.<br></blockquote><div><br><div class="gmail_default" style="font-size:small;color:rgb(51,51,153);display:inline">OK I think I got it. 'reload' deals with a running instance while 'upgrade' starts a new one from the binary on disk, so it makes sense to check the configuration against the binary when upgrading but not when reloading in case the binary on disk changed in between.<br>
The latter is a weirdest-case scenario (since you change the binary when you want to upgrade something, which won't result in a 'reload' call), though possible...<br><br>You decision makes sense and is the safest. Thanks for your lights on that.<br>
</div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> Testing conf is of course a duplicate of work, but that's a safe operation.<br>
> The command output will determine if your new configuration will work<br>
> without having to carefully watch logs with anxiety.<br>
<br>
As I already tried to explain, watching logs is required anyway.<br></blockquote><div><br><div class="gmail_default" style="font-size:small;color:rgb(51,51,153);display:inline">... if you had changes between the binary on disk and the one being run. Which is highly unlikely to happen as calling 'reload' on the current process would mean applying the configuration made for the new binary to the old running one (which needs to be replaced ASAP since it can't resist to a server restart...). But yeah, in that weird case, you'll watch the logs.<br>
</div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> > There is the "upgrade" command in the init script shipped with<br>
> > <a href="http://nginx.org" target="_blank">nginx.org</a> linux packages.<br>
> ><br>
><br>
> Ok, so could Li have used the 'upgrade' command insted of 'reload' to<br>
> reload the configuration and change the allocated memory?<br>
<br>
Yes.<br></blockquote><div><br><div class="gmail_default" style="font-size:small;color:rgb(51,51,153);display:inline">Thanks.<br><br></div><div class="gmail_default" style="font-size:small;color:rgb(51,51,153);display:inline">
Your input has been much appreciated, as always...<br></div></div></div><font size="1"><span style="color:rgb(102,102,102)">---<br></span><b><span style="color:rgb(102,102,102)">B. R.</span></b><span style="color:rgb(102,102,102)"></span></font>
</div></div>