<div dir="ltr">Sorry, what is `with.min` and `without.min` in this case?<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 2, 2017 at 2:47 PM, Maxim Dounin <span dir="ltr"><<a href="mailto:mdounin@mdounin.ru" target="_blank">mdounin@mdounin.ru</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello!<br>
<span class=""><br>
On Thu, Feb 02, 2017 at 09:40:56AM +0200, Donatas Abraitis wrote:<br>
<br>
> I do not cover any tests, just putting this patchset and wanna ask if<br>
> someone had tried this? I tried this for Redis and changes are really<br>
> reasonably visible like here: <a href="https://github.com/antirez/redis/pull/3773" rel="noreferrer" target="_blank">https://github.com/antirez/<wbr>redis/pull/3773</a><br>
<br>
</span>Just a side note:<br>
<br>
The data provided in the pull request is not really convincing.<br>
Ministat shows no difference proven at 95% confidence for both min<br>
and max latency values:<br>
<br>
$ ministat with.min without.min<br>
x with.min<br>
+ without.min<br>
+-----------------------------<wbr>------------------------------<wbr>-------------------+<br>
|x                                  x  x   x+ +          +              x +   +|<br>
|            |________________________AM___<wbr>_|____________M__A__|_________<wbr>__|   |<br>
+-----------------------------<wbr>------------------------------<wbr>-------------------+<br>
    N           Min           Max        Median           Avg        Stddev<br>
x   5        458752        702022        587727      585944.6     86500.993<br>
+   5        605029        722469        649593      659764.4     53243.639<br>
No difference proven at 95.0% confidence<br>
$ ministat with.max without.max<br>
x with.max<br>
+ without.max<br>
+-----------------------------<wbr>------------------------------<wbr>-------------------+<br>
|x                                   + x   xx     +                +   +      *|<br>
|             |__________________________A_<wbr>M|________________A_____M|____<wbr>____| |<br>
+-----------------------------<wbr>------------------------------<wbr>-------------------+<br>
    N           Min           Max        Median           Avg        Stddev<br>
x   5      26625442 2.0884278e+08 1.2690286e+08 1.2130263e+08      64656095<br>
+   5 1.1113228e+08 2.0951387e+08 1.8428094e+08 1.6806744e+08      40111502<br>
No difference proven at 95.0% confidence<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Maxim Dounin<br>
<a href="http://nginx.org/" rel="noreferrer" target="_blank">http://nginx.org/</a><br>
______________________________<wbr>_________________<br>
nginx mailing list<br>
<a href="mailto:nginx@nginx.org">nginx@nginx.org</a><br>
<a href="http://mailman.nginx.org/mailman/listinfo/nginx" rel="noreferrer" target="_blank">http://mailman.nginx.org/<wbr>mailman/listinfo/nginx</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Donatas<br></div>
</div>