<div dir="ltr"><div class="gmail_default" style="font-size:small;color:rgb(51,51,153)">If you think you spot a bug, You'd better open a ticket on <a href="https://trac.nginx.org/">Trac</a>.<br><br></div><div class="gmail_default" style="font-size:small;color:rgb(51,51,153)">You could also talk about development matters on the <a href="http://mailman.nginx.org/mailman/listinfo/nginx-devel">nginx-devel</a> Mailling List. This is the 'users' ML, centered on use cases/configuration/help with/discussions around the software.<br></div><div class="gmail_extra"><div><div class="gmail_signature" data-smartmail="gmail_signature"><font size="1"><span style="color:rgb(102,102,102)">---<br></span><b><span style="color:rgb(102,102,102)">B. R.</span></b><span style="color:rgb(102,102,102)"></span></font></div></div>
<br><div class="gmail_quote">On Thu, Feb 16, 2017 at 4:59 AM, <a href="mailto:alexc@sbrella.com">alexc@sbrella.com</a> <span dir="ltr"><<a href="mailto:alexc@sbrella.com" target="_blank">alexc@sbrella.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>
<div><span></span>Hi，</div><div><br></div><div><div style="font-family:微软雅黑,Tahoma;line-height:normal">In file /src/http/ngx_http_upstream.c, function</div><div style="font-family:微软雅黑,Tahoma;line-height:normal">ngx_http_upstream_finalize_<wbr>request</div><div style="font-family:微软雅黑,Tahoma;line-height:normal"> </div><div style="font-family:微软雅黑,Tahoma;line-height:normal"> </div><div style="font-family:微软雅黑,Tahoma;line-height:normal">// if u->pipe == NULL, ngx_http_file_cache_free(r-><wbr>cache, u->pipe->temp_file); will dereference a null pointer, it's that right ?</div><div style="font-family:微软雅黑,Tahoma;line-height:normal"> </div><div style="font-family:微软雅黑,Tahoma;line-height:normal">// Regards</div><div style="font-family:微软雅黑,Tahoma;line-height:normal">// Alex</div><div style="font-family:微软雅黑,Tahoma;line-height:normal"> </div><div style="font-family:微软雅黑,Tahoma;line-height:normal">if (u->store && u->pipe && u->pipe->temp_file</div><div style="font-family:微软雅黑,Tahoma;line-height:normal">        && u->pipe->temp_file->file.fd != NGX_INVALID_FILE)</div><div style="font-family:微软雅黑,Tahoma;line-height:normal">    {</div><div style="font-family:微软雅黑,Tahoma;line-height:normal">        if (ngx_delete_file(u->pipe-><wbr>temp_file->file.name.data)</div><div style="font-family:微软雅黑,Tahoma;line-height:normal">            == NGX_FILE_ERROR)</div><div style="font-family:微软雅黑,Tahoma;line-height:normal">        {</div><div style="font-family:微软雅黑,Tahoma;line-height:normal">            ngx_log_error(NGX_LOG_CRIT, r->connection->log, ngx_errno,</div><div style="font-family:微软雅黑,Tahoma;line-height:normal">                          ngx_delete_file_n " \"%s\" failed",</div><div style="font-family:微软雅黑,Tahoma;line-height:normal">                          u->pipe->temp_file-><a href="http://file.name">file.name</a>.<wbr>data);</div><div style="font-family:微软雅黑,Tahoma;line-height:normal">        }</div><div style="font-family:微软雅黑,Tahoma;line-height:normal">    }</div><div style="font-family:微软雅黑,Tahoma;line-height:normal"> </div><div style="font-family:微软雅黑,Tahoma;line-height:normal">#if (NGX_HTTP_CACHE)</div><div style="font-family:微软雅黑,Tahoma;line-height:normal"> </div><div style="font-family:微软雅黑,Tahoma;line-height:normal">    if (r->cache) {</div><div style="font-family:微软雅黑,Tahoma;line-height:normal"> </div><div style="font-family:微软雅黑,Tahoma;line-height:normal">      ......</div><div style="font-family:微软雅黑,Tahoma;line-height:normal"> </div><div style="font-family:微软雅黑,Tahoma;line-height:normal">        ngx_http_file_cache_free(r-><wbr>cache, u->pipe->temp_file);          </div><div style="font-family:微软雅黑,Tahoma;line-height:normal">    }</div><div style="font-family:微软雅黑,Tahoma;line-height:normal"> </div></div>
<div><br></div><hr style="width:210px;height:1px" size="1" color="#b5c4df" align="left"><span class="HOEnZb"><font color="#888888">
<div><span><div style="MARGIN:10px;FONT-FAMILY:verdana;FONT-SIZE:10pt"><div><a href="mailto:alexc@sbrella.com" target="_blank">alexc@sbrella.com</a></div></div></span></div>
</font></span></div><br>______________________________<wbr>_________________<br>
nginx mailing list<br>
<a href="mailto:nginx@nginx.org">nginx@nginx.org</a><br>
<a href="http://mailman.nginx.org/mailman/listinfo/nginx" rel="noreferrer" target="_blank">http://mailman.nginx.org/<wbr>mailman/listinfo/nginx</a><br></blockquote></div><br></div></div>