nginx-devel September 2010

nginx-devel@nginx.org

8 participants
14 discussions

[PATCH] Fix ./configure script for less error-forgiving compilers

by Piotr Sikora

Hi Igor, attached patch fixes ./configure script for less error-forgiving compilers (like LLVM/clang) when they are used with -Werror option. auto/types/sizeof: - printf() is defined in missing <stdio.h> header, - sizeof() returns size_t type, which has different signedness on different operating systems (hence %z). auto/unix: - setproctitle() is defined in <stdlib.h> on both: NetBSD and OpenBSD. Best regards, Piotr Sikora < piotr.sikora(a)frickle.com >

10 years, 5 months

Patch for Age header

by Woon Wai Keen

Hi all, I would like to contribute a patch to provide the cached file age as a variable $proxy_cache_age , which can then be used together with add_header Age $proxy_cache_age. The age calculation is not RFC2616 compliant (13.2.3) as it doesn't take into consideration the cached origin Age header and Date. Is it feasible to extract this from the cached headers? -- regards, wK

10 years, 10 months

XSLT Parameter parsing

by Laurence Rowe

XSLT parameter parsing currently allows paramters to be passed one per line or multiple per line separated by a colon (:). http://wiki.nginx.org/NginxHttpXsltModule#xslt_stylesheet location / { xslt_stylesheet /site/xslt/one.xslt $arg_xslt_params param1='$value1': param2=value2 param3=value3; } This has the unfortunate effect of preventing xpath parameters being passed as url parameters when they contain a colon (fairly common in xpath as a namespace or axis specififer). Consider the following configuration: location / { xslt_stylesheet filter.xsl xpath=$arg_xpath; } I would like to be able to call call the url /doc.xml?xpath=ancestor-or-self::entry, but the current parameter parsing code interprets this as multiple invalid parameters ``xpath=ancestor-or-self``, ````, ``entry``. As far as I can tell there is no way to substitute ":" for "%3A" in a variable. The attached patch removes support for specifying multiple parameters in a single line. You may still supply multiple parameters to an xslt by supplying one per line. (I've split the patch into two changesets for readability.) As an alternative it may be possible to preserve the current behaviour by splitting parameters before the call to ngx_http_complex_value which performs the variable substitution, however I was unable to work out how to do this myself. Laurence

11 years, 10 months

stalled cache updating, error:0

by Franchoze Eric

010/09/15 07:32:46 [alert] 15486#0: *367785 stalled cache updating, error:0 while closing request, client: unix:, server: unix:/tmp/nginx7080.socket 2010/09/15 07:47:45 [alert] 15486#0: *578765 stalled cache updating, error:0 while closing request, client: unix:, server: unix:/tmp/nginx7080.socket 2010/09/15 07:47:48 [alert] 15489#0: *579275 stalled cache updating, error:0 while closing request, client: unix:, server: unix:/tmp/nginx7080.socket 2010/09/15 07:48:10 [alert] 15486#0: *584688 stalled cache updating, error:0 while closing request, client: unix:, server: unix:/tmp/nginx7080.socket 2010/09/15 07:49:35 [alert] 15487#0: *603386 stalled cache updating, error:0 while closing request, client: unix:, server: unix:/tmp/nginx7080.socket 2010/09/15 08:02:53 [alert] 15489#0: *784723 stalled cache updating, error:0 while closing request, client: unix:, server: unix:/tmp/nginx7080.socket 2010/09/15 08:05:02 [alert] 15489#0: *813570 stalled cache updating, error:0 while closing request, client: unix:t, server: unix:/tmp/nginx7080.socket Should this if has c->error check? if (c->updating) { ngx_log_error(NGX_LOG_ALERT, c->file.log, 0, "stalled cache updating, error:%ui", c->error); } #/usr/local/nginx-testing/sbin/nginx -V nginx version: afts/0.8.50 built by gcc 4.1.2 20080704 (Red Hat 4.1.2-48) configure arguments: --prefix=/usr/local/nginx-testing --with-debug # Happens when cache grows to 2.5G. #find . |wc -l 208906 #cat /usr/local/nginx-testing/conf/nginx.conf worker_processes 4; worker_rlimit_core 10000000000000000; working_directory /tmp; events { use epoll; worker_connections 10240; multi_accept on; } http { proxy_cache_path /var/www/cache levels=1:1:2 keys_zone=my-cache:1024m max_size=20g inactive=30m; proxy_temp_path /var/www/cache/tmp; include mime.types; default_type text/plain; access_log off; sendfile on; tcp_nopush on; keepalive_timeout 1; keepalive_requests 30; client_header_buffer_size 32k; large_client_header_buffers 8 32k; resolver 127.0.0.1; server { listen unix:/tmp/nginx7080.socket; gzip_proxied any; error_log logs/error_7080_alert.log alert; server_name hss; location / { proxy_pass http://$host$request_uri; proxy_cache my-cache; proxy_buffers 16 64k; proxy_buffer_size 64k; proxy_cache_valid 404 1d; proxy_cache_valid 200 301 302 304 10m; log_format cache '***$time_local ' '$upstream_cache_status ' 'Cache-Control: $upstream_http_cache_control ' '"$request" ($status) '; access_log logs/cache_nginx_access.log cache; } } }

11 years, 11 months

How to avoid deadlock?

by witekfl Gazeta.pl

I want to write mod_layout the right way. layout have to insert "header" after the body element, or at the top it there is no body element, but there should be no header when there is no body and there is </frameset> on the page. I modified sub_filter_module: http://rkd.republika.pl/NGINX/ngx_http_sub2_filter_module.c Config options are similar to sub_filter. I'm using: sub2_filter <body 'HEADER<br/>'; sub2_filter_once on; sub2_frameset </frameset>; Sometimes it works, but when I set output_buffers to 1 1; it stopped working with html like this: <frameset cols="50%,50%"> <frame name ="a" src="a.html"/> <frame name="b" src="b.html"/> </framset> How to make it work, especially how to achieve inserting something before whole document, when there is no <body> in the document?

11 years, 11 months

nginx as proxy for nginx for testing

by Franchoze Eric

Does somebody know if it's possible to specify nginx to get special urls or files from other nginx? I want to bring up nginx on separate port to have possibility to test it without custom modules. Thanks.

11 years, 11 months

(non-critical) typo in 0.8.50 - "ngx_http_set_comlex_value_slot"

by Woon Wai Keen

Hi, I looked at the 0.8.49 to .50 diff today and came across the function "ngx_http_set_comlex_value_slot()" , looking at the function body it looks like it should be spelled "ngx_http_set_complex_value_slot()". -- regards, wK

11 years, 11 months

[PATCH] autoindex_ignore directive

by Derrick Petzold

Hello, This patch adds support for ignoring files in the auto index. Its modeled somewhat after Apache's IndexIgnore http://httpd.apache.org/docs/2.0/mod/mod_autoindex.html#indexignore and its implementation is based off of gzip_disable. Here is a sample config. | autoindex on; | | location /ubuntu/ { | autoindex_ignore (db|conf); # with pcre | autoindex_ignore db conf; # without pcre | } Its supported with or without the pcre library. Without pcre it just does a simple string compare. Either way it can take multiple arguments. It is meant to be used with the existing acl framework so a more complete config would look something like this | autoindex on; | location /ubuntu/ { | autoindex_ignore (db|conf); | } | location ~ /ubuntu/(db|conf)/ { | deny all; | } Questions and comments are welcome. Regards, Derrick ---- diff --git a/src/http/modules/ngx_http_autoindex_module.c b/src/http/modules/ngx_http_autoindex_module. c index b679318..0792aba 100644 --- a/src/http/modules/ngx_http_autoindex_module.c +++ b/src/http/modules/ngx_http_autoindex_module.c @@ -39,6 +39,7 @@ typedef struct { ngx_flag_t enable; ngx_flag_t localtime; ngx_flag_t exact_size; + ngx_array_t *ignore; } ngx_http_autoindex_loc_conf_t; @@ -55,7 +56,8 @@ static ngx_int_t ngx_http_autoindex_init(ngx_conf_t *cf); static void *ngx_http_autoindex_create_loc_conf(ngx_conf_t *cf); static char *ngx_http_autoindex_merge_loc_conf(ngx_conf_t *cf, void *parent, void *child); - +static char *ngx_http_autoindex_ignore(ngx_conf_t *cf, + ngx_command_t *cmd, void *conf); static ngx_command_t ngx_http_autoindex_commands[] = { @@ -80,6 +82,13 @@ static ngx_command_t ngx_http_autoindex_commands[] = { offsetof(ngx_http_autoindex_loc_conf_t, exact_size), NULL }, + { ngx_string("autoindex_ignore"), + NGX_HTTP_MAIN_CONF|NGX_HTTP_SRV_CONF|NGX_HTTP_LOC_CONF|NGX_CONF_1MORE, + ngx_http_autoindex_ignore, + NGX_HTTP_LOC_CONF_OFFSET, + 0, + NULL }, + ngx_null_command }; @@ -132,6 +141,80 @@ static u_char tail[] = "</html>" CRLF ; +static char * +ngx_http_autoindex_ignore(ngx_conf_t *cf, ngx_command_t *cmd, void *conf) +{ + ngx_http_autoindex_loc_conf_t *alcf = conf; + ngx_str_t *value; + +#if (NGX_PCRE) + ngx_uint_t i; + ngx_regex_elt_t *re; + ngx_regex_compile_t rc; + u_char errstr[NGX_MAX_CONF_ERRSTR]; + + if (alcf->ignore == NGX_CONF_UNSET_PTR) { + alcf->ignore = ngx_array_create(cf->pool, 2, sizeof(ngx_regex_elt_t)); + if (alcf->ignore == NULL) { + return NGX_CONF_ERROR; + } + } + + value = cf->args->elts; + + ngx_memzero(&rc, sizeof(ngx_regex_compile_t)); + + rc.pool = cf->pool; + rc.err.len = NGX_MAX_CONF_ERRSTR; + rc.err.data = errstr; + + for (i = 1; i < cf->args->nelts; i++) { + re = ngx_array_push(alcf->ignore); + if (re == NULL) { + return NGX_CONF_ERROR; + } + + rc.pattern = value[i]; + rc.options = NGX_REGEX_CASELESS; + + if (ngx_regex_compile(&rc) != NGX_OK) { + ngx_conf_log_error(NGX_LOG_EMERG, cf, 0, "%V", &rc.err); + return NGX_CONF_ERROR; + } + + re->regex = rc.regex; + re->name = value[i].data; + } + + return NGX_CONF_OK; + +#else + ngx_uint_t i; + ngx_str_t *str; + + if (alcf->ignore == NGX_CONF_UNSET_PTR) { + alcf->ignore = ngx_array_create(cf->pool, 2, sizeof(ngx_str_t)); + if (alcf->ignore == NULL) { + return NGX_CONF_ERROR; + } + } + + value = cf->args->elts; + + for (i = 1; i < cf->args->nelts; i++) { + str = ngx_array_push(alcf->ignore); + if (str == NULL) { + return NGX_CONF_ERROR; + } + + str->data = value[i].data; + str->len = value[i].len; + } + + return NGX_CONF_OK; +#endif +} + static ngx_int_t ngx_http_autoindex_handler(ngx_http_request_t *r) @@ -281,6 +364,40 @@ ngx_http_autoindex_handler(ngx_http_request_t *r) continue; } +#if (NGX_PCRE) + + { + ngx_str_t str; + str.data = ngx_de_name(&dir); + str.len = len; + + if (alcf->ignore && ngx_regex_exec_array(alcf->ignore, + &str, + r->connection->log) + != NGX_DECLINED) + { + continue; + } + } +#else + { + u_int found_match = 0; + ngx_str_t *s; + if (alcf->ignore) { + s = alcf->ignore->elts; + for (i = 0; i < alcf->ignore->nelts; i++) { + if (ngx_strcmp(ngx_de_name(&dir), s[i].data) == 0) { + found_match = 1; + break; + } + } + if (found_match) { + continue; + } + } + } +#endif + if (!dir.valid_info) { /* 1 byte for '/' and 1 byte for terminating '\0' */ @@ -633,6 +750,7 @@ ngx_http_autoindex_create_loc_conf(ngx_conf_t *cf) conf->enable = NGX_CONF_UNSET; conf->localtime = NGX_CONF_UNSET; conf->exact_size = NGX_CONF_UNSET; + conf->ignore = NGX_CONF_UNSET_PTR; return conf; } @@ -647,6 +765,7 @@ ngx_http_autoindex_merge_loc_conf(ngx_conf_t *cf, void *parent, void *child) ngx_conf_merge_value(conf->enable, prev->enable, 0); ngx_conf_merge_value(conf->localtime, prev->localtime, 0); ngx_conf_merge_value(conf->exact_size, prev->exact_size, 1); + ngx_conf_merge_ptr_value(conf->ignore, prev->ignore, NULL); return NGX_CONF_OK; }

11 years, 11 months

Help with open-source project

by Eugaia

Hi guys, I hope nobody minds me asking for help in this way. I'm asking for help from programmers to help set up a unique open-source project that could benefit a great many people. The Tagmata Project's three aims are : (1) to create a completely open-source website (2) to use the site to generate money (3) to use the profits to help alleviate poverty Full details of the whole project can be found at http://www.tagmata.info. The platform for the open-source website has not yet been built, and that is what I'm asking for help with. There are two things in particular that seem most relevant to Nginx developers / users : (1) Nginx - MongoDB module The Tagmata database will use MongoDB, with an Nginx front-end. We're looking to develop an Nginx module that connects to MongoDB, to allow queries through Nginx to MongoDB (in a similar vein to the recent ngx_drizzle, ngx_postgres etc modules that have been developed recently by Agentzh, Piotr Sikora et al.). This might be able to reuse some code from the ngx_gridfs module, but I'm not sure how stable it is. Another part of this module will be translating our own database query language (Tagmata Query Language) to MongoDB queries - which should be pretty easy, as the syntax is very similar. The code for this will be hosted on GitHub, and will be designed in such a way that it will be reusable for other projects that wish to connect to MongoDB that don't want to use Tagmata Query Language. Once this particular module is written and stable, I'll post here to let Nginx users know. (2) Online development tools In order to facilitate adding/modifying of code on the open-source website, we're developing our own tools to make this easy. These will be written in our own scripting language (a cross between PHP and Javascript/Ruby - see http://www.tagmata.info/development/info/TPL for details). The code for these will be made available on the open-source website (tagmata.com) when the base platform has been developed. I can do all of this code myself, but I'm hoping that some generous programmers would be willing to help out to make the task easier. Some other programmers have volunteered to do some of the other tasks that need doing, but we could do with some more help to speed up the development process. If you'd like to know more about the project, please visit http://www.tagmata.info. If you'd like to know more about the programming tasks, please visit http://www.tagmata.info/development/programming. If you'd like to get involved, please contact me by email (dev(a)tagmata.com) or IRC (Freenode #tagmata). Thanks in advance, Marcus Clyne.

11 years, 11 months

nginx segfaults on CentOS 64 bit

by Franchoze Eric

Igor and Maxim, all stack traces I reported before were caused by glibc bug in CentOS that corrupted memory. It was the reason on nginx faul in random place. I's sorry for taking your time and thanks for loooking into this issue. In CentOs MALLOC_CHECK_ is enabled by default. And causes memory corruption for applications. More info is here: http://www.pubbs.net/200911/kde/23500-deactivate-malloccheck-on-x8664.html Patch to fix it is here: http://sourceware.org/bugzilla/show_bug.cgi?id=10282 So it's possible to fix glibc or export MALLOC_CHECK_=3 to avoid random crashes (which unfirtunatelly began happen after enabling cache).

11 years, 11 months

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

nginx-devel September 2010