On Sun, Jan 22, 2017 at 4:07 PM Alon Blayer-Gat <alon.blayergat(a)gmail.com>
> Sure. Thanks for the feedback. I made is simpler.
> evil 'if in location' removed :). I also removed the 'gunzip types;'
> And now we now only have 'gunzip off|on|always'
> But then again, with 'always', one must specify with 'gunzip_types' the
> mime types to always gunzip.
> The rational is that if we want to always gunzip, then it's probably not
> because the client does not support it but rather because we would like to
> modify the response. In which case, it is needed only for specific content
> Default mime type is text/html ( similar to gzip_types).
> I thought of your suggestion of making a more generic mechanism to be used
> by modules directly. It would require modifications in existing modules to
> make the feature usable.
> This patch suggests a simple change for the benefit of existing
> text-related body-filter modules.
> Hope it makes sense.
> Patch attached.
> On Wed, Dec 7, 2016 at 5:58 PM Maxim Dounin <mdounin(a)mdounin.ru> wrote:
> > Hello!
> > On Sun, Nov 27, 2016 at 02:27:56PM +0200, Alon Blayer-Gat wrote:
> > > Hi,
> > >
> > > 1) 'gunzip always' option will gunzip even if the client supports it.
> > > 2) 'gunzip types', like 'always' but only for file types specified
> > > with 'gunzip_types <mime-types>'
> > > 3) Allow gunzip and gunzip_types directives within "if in location"
> > > block (rewrite phase condition).
> > >
> > > The suggested changes are needed, mainly, to allow dynamic
> > > modification of compressed response (e.g. with the 'sub_filter'
> > > module)
> > > 'types' and 'if in location' may allow a more selective operation.
> > No, thanks.
> > "If in location" is evil, don't even try to suggest patches to
> > allow directives in the "if in location" context.
> > As for other changes - I can't say I like them as well. We may
> > consider something as simple as "gunzip always", but additional
> > types filter certainly looks like an overkill. Rather it should
> > be some more generic mechanism to require gunzipping, may be
> > useable by modules directly.
> > [...]
> > --
> > Maxim Dounin
> > http://nginx.org/
> > _______________________________________________
> > nginx-devel mailing list
> > nginx-devel(a)nginx.org
> > http://mailman.nginx.org/mailman/listinfo/nginx-devel
> nginx-devel mailing list
Quite minor, but as far as I can tell, this field is not being used
# HG changeset patch
# User Thibault Charbonnier <thibaultcha(a)fastmail.com>
# Date 1485309159 28800
# Tue Jan 24 17:52:39 2017 -0800
# Branch remove-unused-upstream-struct-field
# Node ID bb5d6b4762998d1ca8f9ad487fa0e9bf6e0094e9
# Parent d84f48e571e449ee6c072a8d52cdea8e06b88ef7
Upstream: remove unused struct field
diff -r d84f48e571e4 -r bb5d6b476299 src/http/ngx_http_upstream.h
--- a/src/http/ngx_http_upstream.h Tue Jan 24 17:02:19 2017 +0300
+++ b/src/http/ngx_http_upstream.h Tue Jan 24 17:52:39 2017 -0800
@@ -151,7 +151,6 @@
- ngx_msec_t timeout;