nginx-devel January 2020

nginx-devel@nginx.org

23 participants
44 discussions

by Maxim Dounin

Hello! On Tue, Sep 18, 2018 at 08:12:20AM -0400, Thomas Ward wrote: > Downstream in Ubuntu, it has been proposed to demote pcre3 and > use pcre2 instead as it is newer. > https://trac.nginx.org/nginx/ticket/720 shows it was marked 4 > years ago that NGINX does not support pcre2. Are there any > plans to use pcre2 instead of pcre3? There are no immediate plans. When we last checked, there were no problems with PCRE, but PCRE2 wasn't available in most distributions we support, making the switch mostly meaningless. Also, it looks like PCRE2 is still not supported even by Exim, which is the parent project of PCRE and PCRE2: https://bugs.exim.org/show_bug.cgi?id=1878 As such, adding PCRE2 support to nginx looks premature. -- Maxim Dounin http://mdounin.ru/

1 year, 1 month

cache: move open to thread pool

by Ka-Hing Cheung

commit 0bcfefa040abdff674047c15701d237ff16a5f2b Author: Ka-Hing Cheung <kahing(a)cloudflare.com> Date: Fri Aug 3 13:37:58 2018 -0700 move open to thread pool At cloudflare we found that open() can block a long time, especially at p99 and p999. Moving it to thread pool improved overall p99 by 6x or so during peak time. This has the side effect of disabling nginx's open_file_cache when "aio threads" is turned on. For us we found that to have no impact (probably because we have way too many files for open file cache to be effective anyway). thread pool does increase CPU usage somewhat but we have not measured difference in CPU usage for stock "aio threads" compared to after this patch. Only the cache hit open() is moved to thread pool. We wrote more about it here: https://blog.cloudflare.com/how-we-scaled-nginx-and-saved-the-world-54-year… diff --git src/core/ngx_open_file_cache.c src/core/ngx_open_file_cache.c index b23ee78d..9177ebfd 100644 --- src/core/ngx_open_file_cache.c +++ src/core/ngx_open_file_cache.c @@ -35,8 +35,6 @@ static ngx_fd_t ngx_open_file_wrapper(ngx_str_t *name, ngx_int_t access, ngx_log_t *log); static ngx_int_t ngx_file_info_wrapper(ngx_str_t *name, ngx_open_file_info_t *of, ngx_file_info_t *fi, ngx_log_t *log); -static ngx_int_t ngx_open_and_stat_file(ngx_str_t *name, - ngx_open_file_info_t *of, ngx_log_t *log); static void ngx_open_file_add_event(ngx_open_file_cache_t *cache, ngx_cached_open_file_t *file, ngx_open_file_info_t *of, ngx_log_t *log); static void ngx_open_file_cleanup(void *data); @@ -836,7 +834,7 @@ ngx_file_info_wrapper(ngx_str_t *name, ngx_open_file_info_t *of, } -static ngx_int_t +ngx_int_t ngx_open_and_stat_file(ngx_str_t *name, ngx_open_file_info_t *of, ngx_log_t *log) { diff --git src/core/ngx_open_file_cache.h src/core/ngx_open_file_cache.h index d119c129..94b4d552 100644 --- src/core/ngx_open_file_cache.h +++ src/core/ngx_open_file_cache.h @@ -124,6 +124,8 @@ ngx_open_file_cache_t *ngx_open_file_cache_init(ngx_pool_t *pool, ngx_uint_t max, time_t inactive); ngx_int_t ngx_open_cached_file(ngx_open_file_cache_t *cache, ngx_str_t *name, ngx_open_file_info_t *of, ngx_pool_t *pool); +ngx_int_t ngx_open_and_stat_file(ngx_str_t *name, + ngx_open_file_info_t *of, ngx_log_t *log); #endif /* _NGX_OPEN_FILE_CACHE_H_INCLUDED_ */ diff --git src/http/ngx_http_cache.h src/http/ngx_http_cache.h index f9e96640..2910f6a1 100644 --- src/http/ngx_http_cache.h +++ src/http/ngx_http_cache.h @@ -114,6 +114,7 @@ struct ngx_http_cache_s { unsigned exists:1; unsigned temp_file:1; unsigned purged:1; + unsigned opening:1; unsigned reading:1; unsigned secondary:1; unsigned background:1; diff --git src/http/ngx_http_file_cache.c src/http/ngx_http_file_cache.c index 56866fa4..9cb110bf 100644 --- src/http/ngx_http_file_cache.c +++ src/http/ngx_http_file_cache.c @@ -18,6 +18,10 @@ static void ngx_http_file_cache_lock_wait(ngx_http_request_t *r, ngx_http_cache_t *c); static ngx_int_t ngx_http_file_cache_read(ngx_http_request_t *r, ngx_http_cache_t *c); +static ngx_int_t ngx_http_file_cache_aio_open(ngx_http_request_t *r, + ngx_http_cache_t *c, ngx_int_t *rv); +static ngx_int_t ngx_http_file_cache_do_aio_open(ngx_http_request_t *r, + ngx_http_cache_t *c, ngx_open_file_info_t *of, ngx_int_t *rv); static ssize_t ngx_http_file_cache_aio_read(ngx_http_request_t *r, ngx_http_cache_t *c); #if (NGX_HAVE_FILE_AIO) @@ -268,9 +272,7 @@ ngx_http_file_cache_open(ngx_http_request_t *r) ngx_uint_t test; ngx_http_cache_t *c; ngx_pool_cleanup_t *cln; - ngx_open_file_info_t of; ngx_http_file_cache_t *cache; - ngx_http_core_loc_conf_t *clcf; c = r->cache; @@ -278,6 +280,10 @@ ngx_http_file_cache_open(ngx_http_request_t *r) return NGX_AGAIN; } + if (c->opening) { + return ngx_http_file_cache_aio_open(r, c, &rv); + } + if (c->reading) { return ngx_http_file_cache_read(r, c); } @@ -343,23 +349,33 @@ ngx_http_file_cache_open(ngx_http_request_t *r) goto done; } - clcf = ngx_http_get_module_loc_conf(r, ngx_http_core_module); + return ngx_http_file_cache_aio_open(r, c, &rv); - ngx_memzero(&of, sizeof(ngx_open_file_info_t)); +done: - of.uniq = c->uniq; - of.valid = clcf->open_file_cache_valid; - of.min_uses = clcf->open_file_cache_min_uses; - of.events = clcf->open_file_cache_events; - of.directio = NGX_OPEN_FILE_DIRECTIO_OFF; - of.read_ahead = clcf->read_ahead; + if (rv == NGX_DECLINED) { + return ngx_http_file_cache_lock(r, c); + } - if (ngx_open_cached_file(clcf->open_file_cache, &c->file.name, &of, r->pool) - != NGX_OK) - { - switch (of.err) { + return rv; +} + +static ngx_int_t +ngx_http_file_cache_aio_open(ngx_http_request_t *r, ngx_http_cache_t *c, + ngx_int_t *rv) +{ + ngx_int_t rc; + ngx_open_file_info_t of; + ngx_http_file_cache_t *cache = c->file_cache; - case 0: + rc = ngx_http_file_cache_do_aio_open(r, c, &of, rv); + if (rc == NGX_AGAIN) { + return rc; + } + + if (rc != NGX_OK) { + switch (of.err) { + case NGX_OK: return NGX_ERROR; case NGX_ENOENT: @@ -391,14 +407,13 @@ ngx_http_file_cache_open(ngx_http_request_t *r) done: - if (rv == NGX_DECLINED) { + if (*rv == NGX_DECLINED) { return ngx_http_file_cache_lock(r, c); } - return rv; + return *rv; } - static ngx_int_t ngx_http_file_cache_lock(ngx_http_request_t *r, ngx_http_cache_t *c) { @@ -663,6 +678,127 @@ ngx_http_file_cache_read(ngx_http_request_t *r, ngx_http_cache_t *c) } +#if (NGX_THREADS) +typedef struct { + ngx_str_t name; + ngx_pool_t *pool; + ngx_open_file_info_t of; + ngx_int_t rv; +} ngx_thread_file_open_ctx_t; + +static void +ngx_http_file_cache_thread_open_handler(void *data, ngx_log_t *log) +{ + ngx_thread_file_open_ctx_t *ctx = data; + ngx_pool_t *pool = ctx->pool; + ngx_open_file_info_t *of = &ctx->of; + ngx_pool_cleanup_t *cln; + ngx_pool_cleanup_file_t *clnf; + ngx_int_t rc; + + ngx_log_debug0(NGX_LOG_DEBUG_CORE, log, 0, "thread read handler"); + + cln = ngx_pool_cleanup_add(pool, sizeof(ngx_pool_cleanup_file_t)); + if (cln == NULL) { + ctx->of.err = NGX_ERROR; + return; + } + + of->fd = NGX_INVALID_FILE; + + rc = ngx_open_and_stat_file(&ctx->name, of, pool->log); + if (rc == NGX_OK && !of->is_dir) { + cln->handler = ngx_pool_cleanup_file; + clnf = cln->data; + + clnf->fd = of->fd; + clnf->name = ctx->name.data; + clnf->log = pool->log; + } +} + + +static ngx_int_t +ngx_http_file_cache_thread_open(ngx_http_cache_t *c, ngx_open_file_info_t *of, + ngx_int_t *rv, ngx_pool_t *pool) +{ + ngx_thread_task_t *task; + ngx_thread_file_open_ctx_t *ctx; + ngx_file_t *file = &c->file; + + task = file->thread_task; + + if (task == NULL) { + task = ngx_thread_task_alloc(pool, sizeof(ngx_thread_file_open_ctx_t)); + if (task == NULL) { + return NGX_ERROR; + } + + file->thread_task = task; + } + + ctx = task->ctx; + + if (task->event.complete) { + task->event.complete = 0; + + *of = ctx->of; + *rv = ctx->rv; + return of->err; + } + + task->handler = ngx_http_file_cache_thread_open_handler; + + ctx->pool = pool; + ctx->name = file->name; + ctx->of = *of; + ctx->rv = *rv; + + if (file->thread_handler(task, file) != NGX_OK) { + return NGX_ERROR; + } + + return NGX_AGAIN; +} +#endif + +static ngx_int_t +ngx_http_file_cache_do_aio_open(ngx_http_request_t *r, ngx_http_cache_t *c, + ngx_open_file_info_t *of, ngx_int_t *rv) +{ + ngx_http_core_loc_conf_t *clcf; + + clcf = ngx_http_get_module_loc_conf(r, ngx_http_core_module); + + ngx_memzero(of, sizeof(ngx_open_file_info_t)); + + of->uniq = c->uniq; + of->valid = clcf->open_file_cache_valid; + of->min_uses = clcf->open_file_cache_min_uses; + of->events = clcf->open_file_cache_events; + of->directio = NGX_OPEN_FILE_DIRECTIO_OFF; + of->read_ahead = clcf->read_ahead; + +#if (NGX_THREADS) + if (clcf->aio == NGX_HTTP_AIO_THREADS) { + ngx_int_t rc; + + c->file.thread_task = c->thread_task; + c->file.thread_handler = ngx_http_cache_thread_handler; + c->file.thread_ctx = r; + + rc = ngx_http_file_cache_thread_open(c, of, rv, r->pool); + + c->thread_task = c->file.thread_task; + c->opening = (rc == NGX_AGAIN); + + return rc; + } +#endif + + return ngx_open_cached_file(clcf->open_file_cache, &c->file.name, of, r->pool); +} + static ssize_t ngx_http_file_cache_aio_read(ngx_http_request_t *r, ngx_http_cache_t *c) {

1 year, 4 months

limit_req_zone Documentation Wrong

by Aidan Carson

Hello, I believe the documentation for the limit_req_zone directive on this page is wrong: http://nginx.org/en/docs/http/ngx_http_limit_req_module.html It says that a rate parameter is not optional, but it is. The directive requires at least three parameters, but limit_req_zone $binary_remote_addr zone=limit:64k sync; or limit_req_zone $binary_remote_addr zone=limit:64k zone=limit:64k; are valid, omitting the rate. I see in the code that the default is 1r/s. Perhaps updating the documentation to list the default would be good, or changing the code to have the rate be required. Thank you, Aidan Carson

2 years, 9 months

[PATCH] Fix for the HT on request headers problem (#1752)

by mstavrev＠gmail.com

# HG changeset patch # User Marin Stavrev # Date 1579526641 -7200 # Mon Jan 20 15:24:01 2020 +0200 # Node ID bf238762fdaf03383c2f3c3718c401e6141e3935 # Parent 6439ef81e37dfccfc3a8c57fed278bf56014ef39 Fix for the HT on request headers problem (#1752) When client send HTTP request with a header of Content-Length that starts with horizontal tab character (HT=0x09), Nginx responds with HTTP 400 Bad Request. According to HTTP RFC2616 section 4.2, "... The field value MAY be preceded by any amount of LWS, though a single SP is preferred.". The difinition of LWS is: LWS = [CRLF] 1*( SP | HT ) So a header such as the following should be processed fine: Content-Length:<0x09>110\r\n diff -r 6439ef81e37d -r bf238762fdaf src/http/ngx_http_parse.c --- a/src/http/ngx_http_parse.c Fri Jan 17 12:13:02 2020 +0300 +++ b/src/http/ngx_http_parse.c Mon Jan 20 15:24:01 2020 +0200 @@ -1000,6 +1000,7 @@ case sw_space_before_value: switch (ch) { case ' ': + case '\x9': break; case CR: r->header_start = p; @@ -1023,6 +1024,7 @@ case sw_value: switch (ch) { case ' ': + case '\x9': r->header_end = p; state = sw_space_after_value; break; @@ -1042,6 +1044,7 @@ case sw_space_after_value: switch (ch) { case ' ': + case '\x9': break; case CR: state = sw_almost_done;

2 years, 9 months

submitting a bug report

by Val Kulkov

The "How to report bug" page at trac.nginx.org says: "You need to authorize with Google, GitHub, StackExchange or Yandex to submit bug report." I have logged in to Trac with my GitHub account. I am seeing "logged in as Val Kulkov" in the top line of the page. But there is no way to submit a bug report! There is no button, no link, nothing. I can only see reports, but I cannot open a new ticket. Is there some problem with the Trac server [again]? Can someone check what is going on please? Thanks.

2 years, 10 months

Does NJS support reg ex positive look behinds?

by Shani Ranasinghe

Hi, I would like to know if njs supports regex positive look behinds. I have written a script in perl and would like to convert it to njs. The reg ex I have in perl is "((?<=[a-z])(?=[A-Z])(?!ID)(?!^Open$)|(?<=ABC)|(?<=API)(?=[A-Z])|(?=Connect))" This would give the following outputs. *Inputs and expected outputs* are *listed below* in the format *Input -> Expected Output* 1. InstallAndSetup -> install-and-setup 2. DeployingABCDefGhijk -> deploying-abc-def-ghijk (assuming abc is a noun that is frequently used) 3. OpenIDConnect -> openid-connect 4. OAuth2Scopes->oauth2-scopes 5. APISecurity -> api-security I would like to know if there's a way to achieve this with njs? Thank you in advance. Regards, Shani.

2 years, 10 months

trac is offline

by Val Kulkov

https://trac.nginx.org/ produces "502 Bad Gateway". Can someone look into that please?

2 years, 10 months

Is Nginx being tested on ARM architecture ?

by Martin Grigorov

Hello Nginx developers, I was not able to find any information what continous integration (CI) Nginx project is using. I'd like to ask whether you run a CI server/agent on ARM 32/64 architecture ? At my job we are going to use more and more ARM64 based servers and we would like to know whether this is a safe bet with Nginx. At https://nginx.org/en/index.html <https://nginx.org/en/index.html#tested_os_and_platforms>#tested_os_and_platforms I see " Linux 3 — 4 / armv6l, armv7l, aarch64, ppc64le;". Does that mean that Linux 5.x is not supported/tested or just that this documentation page needs to be updated ? Thank you! Regards, Martin Grigorov

2 years, 10 months

[njs] Fixed callback invocations in "fs" module.

by Dmitry Volyntsev

details: https://hg.nginx.org/njs/rev/2b75ee955589 branches: changeset: 1314:2b75ee955589 user: Artem S. Povalyukhin <artem.povaluhin(a)gmail.com> date: Mon Jan 20 13:24:09 2020 +0300 description: Fixed callback invocations in "fs" module. This closes #200 issue on Github. diffstat: src/njs_fs.c | 799 +++++++++++++++------------------------------- src/test/njs_unit_test.c | 34 +- test/njs_expect_test.exp | 42 +- 3 files changed, 305 insertions(+), 570 deletions(-) diffs (truncated from 1262 to 1000 lines): diff -r b247b1c5531f -r 2b75ee955589 src/njs_fs.c --- a/src/njs_fs.c Wed Jan 22 15:29:47 2020 +0300 +++ b/src/njs_fs.c Mon Jan 20 13:24:09 2020 +0300 @@ -8,37 +8,51 @@ #include <njs_main.h> +#define njs_fs_magic(calltype, mode) \ + (((mode) << 2) | calltype) + + +typedef enum { + NJS_FS_DIRECT, + NJS_FS_PROMISE, + NJS_FS_CALLBACK, +} njs_fs_calltype_t; + + +typedef enum { + NJS_FS_TRUNC, + NJS_FS_APPEND, +} njs_fs_writemode_t; + + typedef struct { - njs_str_t name; - int value; + njs_str_t name; + int value; } njs_fs_entry_t; +typedef struct { + int errn; + const char *desc; + const char *syscall; +} njs_fs_ioerror_t; + + static njs_int_t njs_fs_read_file(njs_vm_t *vm, njs_value_t *args, - njs_uint_t nargs, njs_index_t unused); -static njs_int_t njs_fs_read_file_sync(njs_vm_t *vm, njs_value_t *args, - njs_uint_t nargs, njs_index_t unused); -static njs_int_t njs_fs_append_file(njs_vm_t *vm, njs_value_t *args, - njs_uint_t nargs, njs_index_t unused); + njs_uint_t nargs, njs_index_t calltype); static njs_int_t njs_fs_write_file(njs_vm_t *vm, njs_value_t *args, - njs_uint_t nargs, njs_index_t unused); -static njs_int_t njs_fs_append_file_sync(njs_vm_t *vm, njs_value_t *args, - njs_uint_t nargs, njs_index_t unused); -static njs_int_t njs_fs_write_file_sync(njs_vm_t *vm, njs_value_t *args, - njs_uint_t nargs, njs_index_t unused); -static njs_int_t njs_fs_write_file_internal(njs_vm_t *vm, njs_value_t *args, - njs_uint_t nargs, int default_flags); -static njs_int_t njs_fs_write_file_sync_internal(njs_vm_t *vm, - njs_value_t *args, njs_uint_t nargs, int default_flags); + njs_uint_t nargs, njs_index_t magic); static njs_int_t njs_fs_rename_sync(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs, njs_index_t unused); -static njs_int_t njs_fs_fd_read(njs_vm_t *vm, njs_value_t *path, int fd, - njs_str_t *data); +static njs_int_t njs_fs_fd_read(njs_vm_t *vm, int fd, njs_str_t *data, + njs_fs_ioerror_t *ioerror); static njs_int_t njs_fs_error(njs_vm_t *vm, const char *syscall, const char *description, njs_value_t *path, int errn, njs_value_t *retval); static int njs_fs_flags(njs_str_t *value); static mode_t njs_fs_mode(njs_value_t *value); +static njs_int_t njs_fs_add_event(njs_vm_t *vm, const njs_value_t *callback, + const njs_value_t *err, const njs_value_t *result); static const njs_value_t njs_fs_errno_string = njs_string("errno"); @@ -70,8 +84,8 @@ static njs_fs_entry_t njs_flags_table[] njs_inline njs_int_t -njs_fs_path_arg(njs_vm_t *vm, const char **dst, - const njs_value_t* src, const njs_str_t *prop_name) +njs_fs_path_arg(njs_vm_t *vm, const char **dst, const njs_value_t* src, + const njs_str_t *prop_name) { if (njs_slow_path(!njs_is_string(src))) { njs_type_error(vm, "\"%V\" must be a string", prop_name); @@ -87,21 +101,33 @@ njs_fs_path_arg(njs_vm_t *vm, const char } +njs_inline void +njs_fs_set_ioerr(njs_fs_ioerror_t *ioerror, int errn, const char *desc, + const char *syscall) +{ + ioerror->errn = errn; + ioerror->desc = desc; + ioerror->syscall = syscall; +} + + static njs_int_t njs_fs_read_file(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs, - njs_index_t unused) + njs_index_t calltype) { - int fd, errn, flags; + int fd, flags; u_char *start; size_t size; ssize_t length; njs_str_t flag, encoding, data; njs_int_t ret; - const char *path, *syscall, *description; + const char *path; struct stat sb; - njs_value_t *callback, arguments[3]; + const njs_value_t *callback, *options; + njs_value_t err; njs_object_prop_t *prop; njs_lvlhsh_query_t lhq; + njs_fs_ioerror_t ioerror; ret = njs_fs_path_arg(vm, &path, njs_arg(args, nargs, 1), &njs_str_value("path")); @@ -109,247 +135,28 @@ njs_fs_read_file(njs_vm_t *vm, njs_value return ret; } - if (njs_slow_path(nargs < 3)) { - njs_type_error(vm, "too few arguments"); - return NJS_ERROR; + options = njs_arg(args, nargs, 2); + + if (njs_slow_path(calltype == NJS_FS_CALLBACK)) { + callback = njs_arg(args, nargs, njs_min(nargs - 1, 3)); + if (!njs_is_function(callback)) { + njs_type_error(vm, "\"callback\" must be a function"); + return NJS_ERROR; + } + if (options == callback) { + options = &njs_value_undefined; + } + + } else { + /* GCC complains about uninitialized callback. */ + callback = NULL; } flag.start = NULL; encoding.length = 0; encoding.start = NULL; - if (!njs_is_function(&args[2])) { - if (njs_is_string(&args[2])) { - njs_string_get(&args[2], &encoding); - - } else if (njs_is_object(&args[2])) { - lhq.key_hash = NJS_FLAG_HASH; - lhq.key = njs_str_value("flag"); - lhq.proto = &njs_object_hash_proto; - - ret = njs_lvlhsh_find(njs_object_hash(&args[2]), &lhq); - if (ret == NJS_OK) { - prop = lhq.value; - njs_string_get(&prop->value, &flag); - } - - lhq.key_hash = NJS_ENCODING_HASH; - lhq.key = njs_str_value("encoding"); - lhq.proto = &njs_object_hash_proto; - - ret = njs_lvlhsh_find(njs_object_hash(&args[2]), &lhq); - if (ret == NJS_OK) { - prop = lhq.value; - njs_string_get(&prop->value, &encoding); - } - - } else { - njs_type_error(vm, "Unknown options type " - "(a string or object required)"); - return NJS_ERROR; - } - - if (njs_slow_path(nargs < 4 || !njs_is_function(&args[3]))) { - njs_type_error(vm, "callback must be a function"); - return NJS_ERROR; - } - - callback = &args[3]; - - } else { - if (njs_slow_path(!njs_is_function(&args[2]))) { - njs_type_error(vm, "callback must be a function"); - return NJS_ERROR; - } - - callback = &args[2]; - } - - if (flag.start == NULL) { - flag = njs_str_value("r"); - } - - flags = njs_fs_flags(&flag); - if (njs_slow_path(flags == -1)) { - njs_type_error(vm, "Unknown file open flags: \"%V\"", &flag); - return NJS_ERROR; - } - - if (encoding.length != 0 - && (encoding.length != 4 || memcmp(encoding.start, "utf8", 4) != 0)) - { - njs_type_error(vm, "Unknown encoding: \"%V\"", &encoding); - return NJS_ERROR; - } - - description = NULL; - - /* GCC 4 complains about uninitialized errn and syscall. */ - errn = 0; - syscall = NULL; - - fd = open(path, flags); - if (njs_slow_path(fd < 0)) { - errn = errno; - description = strerror(errno); - syscall = "open"; - goto done; - } - - ret = fstat(fd, &sb); - if (njs_slow_path(ret == -1)) { - errn = errno; - description = strerror(errno); - syscall = "stat"; - goto done; - } - - if (njs_slow_path(!S_ISREG(sb.st_mode))) { - errn = 0; - description = "File is not regular"; - syscall = "stat"; - goto done; - } - - if (encoding.length != 0) { - length = sb.st_size; - - if (length > NJS_STRING_MAP_STRIDE) { - /* - * At this point length is not known, in order to set it to - * the correct value after file is read, we need to ensure that - * offset_map is allocated by njs_string_alloc(). This can be - * achieved by making length != size. - */ - length += 1; - } - - } else { - length = 0; - } - - size = sb.st_size; - - if (njs_fast_path(size != 0)) { - - start = njs_string_alloc(vm, &arguments[2], size, length); - if (njs_slow_path(start == NULL)) { - goto fail; - } - - data.start = start; - data.length = size; - - ret = njs_fs_fd_read(vm, &args[1], fd, &data); - if (ret != NJS_OK) { - goto fail; - } - - start = data.start; - - } else { - /* size of the file is not known in advance. */ - - data.length = 0; - - ret = njs_fs_fd_read(vm, &args[1], fd, &data); - if (ret != NJS_OK) { - goto fail; - } - - size = data.length; - start = data.start; - - ret = njs_string_new(vm, &arguments[2], start, size, length); - if (njs_slow_path(ret != NJS_OK)) { - goto fail; - } - } - - if (encoding.length != 0) { - length = njs_utf8_length(start, size); - - if (length >= 0) { - njs_string_length_set(&arguments[2], length); - - } else { - errn = 0; - description = "Non-UTF8 file, convertion is not implemented"; - syscall = NULL; - goto done; - } - } - -done: - - if (fd != -1) { - (void) close(fd); - } - - if (description != 0) { - (void) njs_fs_error(vm, syscall, description, &args[1], errn, - &arguments[1]); - - njs_set_undefined(&arguments[2]); - - } else { - njs_set_undefined(&arguments[1]); - } - - njs_set_undefined(&arguments[0]); - - ret = njs_function_apply(vm, njs_function(callback), arguments, 3, - &vm->retval); - - if (njs_slow_path(ret != NJS_OK)) { - return ret; - } - - njs_set_undefined(&vm->retval); - - return NJS_OK; - -fail: - - if (fd != -1) { - (void) close(fd); - } - - return NJS_ERROR; -} - - -static njs_int_t -njs_fs_read_file_sync(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs, - njs_index_t unused) -{ - int fd, errn, flags; - u_char *start; - size_t size; - ssize_t length; - njs_str_t flag, encoding, data; - njs_int_t ret; - const char *path, *syscall, *description; - struct stat sb; - njs_object_prop_t *prop; - njs_lvlhsh_query_t lhq; - - ret = njs_fs_path_arg(vm, &path, njs_arg(args, nargs, 1), - &njs_str_value("path")); - if (njs_slow_path(ret != NJS_OK)) { - return ret; - } - - if (njs_slow_path(nargs < 2)) { - njs_type_error(vm, "too few arguments"); - return NJS_ERROR; - } - - flag.start = NULL; - encoding.length = 0; - encoding.start = NULL; - - if (nargs == 3) { + if (njs_slow_path(!njs_is_undefined(options))) { if (njs_is_string(&args[2])) { njs_string_get(&args[2], &encoding); @@ -391,11 +198,6 @@ njs_fs_read_file_sync(njs_vm_t *vm, njs_ return NJS_ERROR; } - path = njs_string_to_c_string(vm, &args[1]); - if (njs_slow_path(path == NULL)) { - return NJS_ERROR; - } - if (encoding.length != 0 && (encoding.length != 4 || memcmp(encoding.start, "utf8", 4) != 0)) { @@ -403,32 +205,22 @@ njs_fs_read_file_sync(njs_vm_t *vm, njs_ return NJS_ERROR; } - description = NULL; - - /* GCC 4 complains about uninitialized errn and syscall. */ - errn = 0; - syscall = NULL; + njs_fs_set_ioerr(&ioerror, 0, NULL, NULL); fd = open(path, flags); if (njs_slow_path(fd < 0)) { - errn = errno; - description = strerror(errno); - syscall = "open"; + njs_fs_set_ioerr(&ioerror, errno, strerror(errno), "open"); goto done; } ret = fstat(fd, &sb); if (njs_slow_path(ret == -1)) { - errn = errno; - description = strerror(errno); - syscall = "stat"; + njs_fs_set_ioerr(&ioerror, errno, strerror(errno), "fstat"); goto done; } if (njs_slow_path(!S_ISREG(sb.st_mode))) { - errn = 0; - description = "File is not regular"; - syscall = "stat"; + njs_fs_set_ioerr(&ioerror, 0, "File is not regular", "stat"); goto done; } @@ -452,7 +244,6 @@ njs_fs_read_file_sync(njs_vm_t *vm, njs_ size = sb.st_size; if (njs_fast_path(size != 0)) { - start = njs_string_alloc(vm, &vm->retval, size, length); if (njs_slow_path(start == NULL)) { goto fail; @@ -461,8 +252,12 @@ njs_fs_read_file_sync(njs_vm_t *vm, njs_ data.start = start; data.length = size; - ret = njs_fs_fd_read(vm, &args[1], fd, &data); + ret = njs_fs_fd_read(vm, fd, &data, &ioerror); if (ret != NJS_OK) { + if (ioerror.desc != NULL) { + goto done; + } + goto fail; } @@ -473,8 +268,12 @@ njs_fs_read_file_sync(njs_vm_t *vm, njs_ data.length = 0; - ret = njs_fs_fd_read(vm, &args[1], fd, &data); + ret = njs_fs_fd_read(vm, fd, &data, &ioerror); if (ret != NJS_OK) { + if (ioerror.desc != NULL) { + goto done; + } + goto fail; } @@ -494,9 +293,9 @@ njs_fs_read_file_sync(njs_vm_t *vm, njs_ njs_string_length_set(&vm->retval, length); } else { - errn = 0; - description = "Non-UTF8 file, convertion is not implemented"; - syscall = NULL; + njs_fs_set_ioerr(&ioerror, 0, + "Non-UTF8 file, convertion is not implemented", + NULL); goto done; } } @@ -507,12 +306,46 @@ done: (void) close(fd); } - if (description != 0) { - return njs_fs_error(vm, syscall, description, &args[1], errn, - &vm->retval); + if (njs_fast_path(calltype == NJS_FS_DIRECT)) { + if (njs_slow_path(ioerror.desc != NULL)) { + (void) njs_fs_error(vm, ioerror.syscall, ioerror.desc, + &args[1], ioerror.errn, &vm->retval); + return NJS_ERROR; + } + + return NJS_OK; + } + + if (calltype == NJS_FS_PROMISE) { + njs_internal_error(vm, "promise callback is not implemented"); + return NJS_ERROR; } - return NJS_OK; + if (calltype == NJS_FS_CALLBACK) { + if (njs_slow_path(ioerror.desc)) { + ret = njs_fs_error(vm, ioerror.syscall, ioerror.desc, + &args[1], ioerror.errn, &err); + if (njs_slow_path(ret != NJS_OK)) { + return ret; + } + + njs_set_undefined(&vm->retval); + + } else { + njs_set_undefined(&err); + } + + ret = njs_fs_add_event(vm, callback, &err, &vm->retval); + if (njs_slow_path(ret != NJS_OK)) { + return ret; + } + + njs_set_undefined(&vm->retval); + return NJS_OK; + } + + njs_internal_error(vm, "invalid calltype"); + return NJS_ERROR; fail: @@ -525,50 +358,20 @@ fail: static njs_int_t -njs_fs_append_file(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs, - njs_index_t unused) -{ - return njs_fs_write_file_internal(vm, args, nargs, - O_APPEND | O_CREAT | O_WRONLY); -} - - -static njs_int_t njs_fs_write_file(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs, - njs_index_t unused) + njs_index_t magic) { - return njs_fs_write_file_internal(vm, args, nargs, - O_TRUNC | O_CREAT | O_WRONLY); -} - - -static njs_int_t njs_fs_append_file_sync(njs_vm_t *vm, njs_value_t *args, - njs_uint_t nargs, njs_index_t unused) -{ - return njs_fs_write_file_sync_internal(vm, args, nargs, - O_APPEND | O_CREAT | O_WRONLY); -} - - -static njs_int_t njs_fs_write_file_sync(njs_vm_t *vm, njs_value_t *args, - njs_uint_t nargs, njs_index_t unused) -{ - return njs_fs_write_file_sync_internal(vm, args, nargs, - O_TRUNC | O_CREAT | O_WRONLY); -} - - -static njs_int_t njs_fs_write_file_internal(njs_vm_t *vm, njs_value_t *args, - njs_uint_t nargs, int default_flags) -{ - int fd, errn, flags; + int fd, flags; u_char *p, *end; mode_t md; ssize_t n; njs_str_t data, flag, encoding; njs_int_t ret; - const char *path, *syscall, *description; - njs_value_t *callback, *mode, arguments[2]; + const char *path; + njs_value_t *mode, err; + njs_fs_calltype_t calltype; + const njs_value_t *callback, *options; + njs_fs_ioerror_t ioerror; njs_object_prop_t *prop; njs_lvlhsh_query_t lhq; @@ -578,14 +381,24 @@ static njs_int_t njs_fs_write_file_inter return ret; } - if (njs_slow_path(nargs < 4)) { - njs_type_error(vm, "too few arguments"); + if (njs_slow_path(!njs_is_string(njs_arg(args, nargs, 2)))) { + njs_type_error(vm, "\"data\" must be a string"); return NJS_ERROR; } - if (njs_slow_path(!njs_is_string(&args[2]))) { - njs_type_error(vm, "data must be a string"); - return NJS_ERROR; + callback = NULL; + calltype = magic & 3; + options = njs_arg(args, nargs, 3); + + if (njs_slow_path(calltype == NJS_FS_CALLBACK)) { + callback = njs_arg(args, nargs, njs_min(nargs - 1, 4)); + if (!njs_is_function(callback)) { + njs_type_error(vm, "\"callback\" must be a function"); + return NJS_ERROR; + } + if (options == callback) { + options = &njs_value_undefined; + } } mode = NULL; @@ -595,191 +408,7 @@ static njs_int_t njs_fs_write_file_inter encoding.length = 0; encoding.start = NULL; - if (!njs_is_function(&args[3])) { - if (njs_is_string(&args[3])) { - njs_string_get(&args[3], &encoding); - - } else if (njs_is_object(&args[3])) { - lhq.key_hash = NJS_FLAG_HASH; - lhq.key = njs_str_value("flag"); - lhq.proto = &njs_object_hash_proto; - - ret = njs_lvlhsh_find(njs_object_hash(&args[3]), &lhq); - if (ret == NJS_OK) { - prop = lhq.value; - njs_string_get(&prop->value, &flag); - } - - lhq.key_hash = NJS_ENCODING_HASH; - lhq.key = njs_str_value("encoding"); - lhq.proto = &njs_object_hash_proto; - - ret = njs_lvlhsh_find(njs_object_hash(&args[3]), &lhq); - if (ret == NJS_OK) { - prop = lhq.value; - njs_string_get(&prop->value, &encoding); - } - - lhq.key_hash = NJS_MODE_HASH; - lhq.key = njs_str_value("mode"); - lhq.proto = &njs_object_hash_proto; - - ret = njs_lvlhsh_find(njs_object_hash(&args[3]), &lhq); - if (ret == NJS_OK) { - prop = lhq.value; - mode = &prop->value; - } - - } else { - njs_type_error(vm, "Unknown options type " - "(a string or object required)"); - return NJS_ERROR; - } - - if (njs_slow_path(nargs < 5 || !njs_is_function(&args[4]))) { - njs_type_error(vm, "callback must be a function"); - return NJS_ERROR; - } - - callback = &args[4]; - - } else { - if (njs_slow_path(!njs_is_function(&args[3]))) { - njs_type_error(vm, "callback must be a function"); - return NJS_ERROR; - } - - callback = &args[3]; - } - - if (flag.start != NULL) { - flags = njs_fs_flags(&flag); - if (njs_slow_path(flags == -1)) { - njs_type_error(vm, "Unknown file open flags: \"%V\"", &flag); - return NJS_ERROR; - } - - } else { - flags = default_flags; - } - - if (mode != NULL) { - md = njs_fs_mode(mode); - - } else { - md = 0666; - } - - if (encoding.length != 0 - && (encoding.length != 4 || memcmp(encoding.start, "utf8", 4) != 0)) - { - njs_type_error(vm, "Unknown encoding: \"%V\"", &encoding); - return NJS_ERROR; - } - - description = NULL; - - /* GCC 4 complains about uninitialized errn and syscall. */ - errn = 0; - syscall = NULL; - - fd = open(path, flags, md); - if (njs_slow_path(fd < 0)) { - errn = errno; - description = strerror(errno); - syscall = "open"; - goto done; - } - - njs_string_get(&args[2], &data); - - p = data.start; - end = p + data.length; - - while (p < end) { - n = write(fd, p, end - p); - if (njs_slow_path(n == -1)) { - if (errno == EINTR) { - continue; - } - - errn = errno; - description = strerror(errno); - syscall = "write"; - goto done; - } - - p += n; - } - -done: - - if (fd != -1) { - (void) close(fd); - } - - if (description != 0) { - (void) njs_fs_error(vm, syscall, description, &args[1], errn, - &arguments[1]); - - } else { - njs_set_undefined(&arguments[1]); - } - - njs_set_undefined(&arguments[0]); - - ret = njs_function_apply(vm, njs_function(callback), arguments, 2, - &vm->retval); - - if (njs_slow_path(ret != NJS_OK)) { - return ret; - } - - njs_set_undefined(&vm->retval); - - return NJS_OK; -} - - -static njs_int_t -njs_fs_write_file_sync_internal(njs_vm_t *vm, njs_value_t *args, - njs_uint_t nargs, int default_flags) -{ - int fd, errn, flags; - u_char *p, *end; - mode_t md; - ssize_t n; - njs_str_t data, flag, encoding; - njs_int_t ret; - const char *path, *syscall, *description; - njs_value_t *mode; - njs_object_prop_t *prop; - njs_lvlhsh_query_t lhq; - - ret = njs_fs_path_arg(vm, &path, njs_arg(args, nargs, 1), - &njs_str_value("path")); - if (njs_slow_path(ret != NJS_OK)) { - return ret; - } - - if (njs_slow_path(nargs < 3)) { - njs_type_error(vm, "too few arguments"); - return NJS_ERROR; - } - - if (njs_slow_path(!njs_is_string(&args[2]))) { - njs_type_error(vm, "data must be a string"); - return NJS_ERROR; - } - - mode = NULL; - /* GCC complains about uninitialized flag.length. */ - flag.length = 0; - flag.start = NULL; - encoding.length = 0; - encoding.start = NULL; - - if (nargs == 4) { + if (njs_slow_path(!njs_is_undefined(options))) { if (njs_is_string(&args[3])) { njs_string_get(&args[3], &encoding); @@ -829,7 +458,8 @@ njs_fs_write_file_sync_internal(njs_vm_t } } else { - flags = default_flags; + flags = O_CREAT | O_WRONLY; + flags |= ((magic >> 2) == NJS_FS_APPEND) ? O_APPEND : O_TRUNC; } if (mode != NULL) { @@ -846,17 +476,11 @@ njs_fs_write_file_sync_internal(njs_vm_t return NJS_ERROR; } - description = NULL; - - /* GCC 4 complains about uninitialized errn and syscall. */ - errn = 0; - syscall = NULL; + njs_fs_set_ioerr(&ioerror, 0, NULL, NULL); fd = open(path, flags, md); if (njs_slow_path(fd < 0)) { - errn = errno; - description = strerror(errno); - syscall = "open"; + njs_fs_set_ioerr(&ioerror, errno, strerror(errno), "open"); goto done; } @@ -872,9 +496,7 @@ njs_fs_write_file_sync_internal(njs_vm_t continue; } - errn = errno; - description = strerror(errno); - syscall = "write"; + njs_fs_set_ioerr(&ioerror, errno, strerror(errno), "write"); goto done; } @@ -887,15 +509,45 @@ done: (void) close(fd); } - if (description != 0) { - return njs_fs_error(vm, syscall, description, &args[1], errn, - &vm->retval); + if (njs_fast_path(calltype == NJS_FS_DIRECT)) { + if (njs_slow_path(ioerror.desc != NULL)) { + (void) njs_fs_error(vm, ioerror.syscall, ioerror.desc, &args[1], + ioerror.errn, &vm->retval); + return NJS_ERROR; + } - } else { njs_set_undefined(&vm->retval); + return NJS_OK; + } + + if (calltype == NJS_FS_PROMISE) { + njs_internal_error(vm, "not implemented"); + return NJS_ERROR; } - return NJS_OK; + if (calltype == NJS_FS_CALLBACK) { + if (ioerror.desc != NULL) { + ret = njs_fs_error(vm, ioerror.syscall, ioerror.desc, &args[1], + ioerror.errn, &err); + if (njs_slow_path(ret != NJS_OK)) { + return ret; + } + + } else { + njs_set_undefined(&err); + } + + ret = njs_fs_add_event(vm, callback, &err, NULL); + if (njs_slow_path(ret != NJS_OK)) { + return ret; + } + + njs_set_undefined(&vm->retval); + return NJS_OK; + } + + njs_internal_error(vm, "invalid calltype"); + return NJS_ERROR; } @@ -920,8 +572,9 @@ njs_fs_rename_sync(njs_vm_t *vm, njs_val ret = rename(old_path, new_path); if (njs_slow_path(ret != 0)) { - return njs_fs_error(vm, "rename", strerror(errno), NULL, errno, + (void) njs_fs_error(vm, "rename", strerror(errno), NULL, errno, &vm->retval); + return NJS_ERROR; } njs_set_undefined(&vm->retval); @@ -931,7 +584,8 @@ njs_fs_rename_sync(njs_vm_t *vm, njs_val static njs_int_t -njs_fs_fd_read(njs_vm_t *vm, njs_value_t *path, int fd, njs_str_t *data) +njs_fs_fd_read(njs_vm_t *vm, int fd, njs_str_t *data, + njs_fs_ioerror_t *ioerror) { u_char *p, *end, *start; size_t size; @@ -956,8 +610,8 @@ njs_fs_fd_read(njs_vm_t *vm, njs_value_t n = read(fd, p, end - p); if (njs_slow_path(n < 0)) { - return njs_fs_error(vm, "read", strerror(errno), path, errno, - &vm->retval); + njs_fs_set_ioerr(ioerror, errno, strerror(errno), "read"); + return NJS_DECLINED; } p += n; @@ -1084,7 +738,7 @@ njs_fs_error(njs_vm_t *vm, const char *s njs_set_object(retval, error); - return NJS_ERROR; + return NJS_OK; } @@ -1127,6 +781,61 @@ njs_fs_mode(njs_value_t *value) } +static njs_int_t +njs_fs_add_event(njs_vm_t *vm, const njs_value_t *callback, + const njs_value_t *err, const njs_value_t *result) +{ + njs_int_t nargs; + njs_event_t *event; + njs_vm_ops_t *ops; + + nargs = (result == NULL) ? 1 : 2; + + ops = vm->options.ops; + if (njs_slow_path(ops == NULL)) { + njs_internal_error(vm, "not supported by host environment"); + return NJS_ERROR; + } + + event = njs_mp_alloc(vm->mem_pool, sizeof(njs_event_t)); + if (njs_slow_path(event == NULL)) { + goto memory_error; + } + + event->destructor = ops->clear_timer; + event->function = njs_function(callback); + event->nargs = nargs; + event->once = 1; + event->posted = 0; + + event->args = njs_mp_alloc(vm->mem_pool, sizeof(njs_value_t) * nargs); + if (njs_slow_path(event->args == NULL)) { + goto memory_error; + } + + /* GC: retain */ + event->args[0] = *err; + + if (nargs == 2) { + event->args[1] = *result; + } + + event->host_event = ops->set_timer(vm->external, 0, event); + if (njs_slow_path(event->host_event == NULL)) { + njs_internal_error(vm, "set_timer() failed"); + return NJS_ERROR; + } + + return njs_add_event(vm, event); +

2 years, 10 months

[njs] Fixed match of native function is backtraces.

by Dmitry Volyntsev

details: https://hg.nginx.org/njs/rev/b247b1c5531f branches: changeset: 1313:b247b1c5531f user: Dmitry Volyntsev <xeioex(a)nginx.com> date: Wed Jan 22 15:29:47 2020 +0300 description: Fixed match of native function is backtraces. Since 6df48738a043 native methods are not uniquely identifiable by a function pointer as several method may share common C function and differ only in magic argument. diffstat: src/njs_builtin.c | 10 ++++++---- src/njs_function.h | 7 +++++++ src/njs_vm.c | 3 +-- src/njs_vm.h | 2 +- src/test/njs_interactive_test.c | 13 +++++++++---- 5 files changed, 24 insertions(+), 11 deletions(-) diffs (116 lines): diff -r 74c2de51636c -r b247b1c5531f src/njs_builtin.c --- a/src/njs_builtin.c Wed Jan 22 15:29:44 2020 +0300 +++ b/src/njs_builtin.c Wed Jan 22 15:29:47 2020 +0300 @@ -15,7 +15,7 @@ typedef struct { NJS_BUILTIN_TRAVERSE_MATCH, } type; - njs_function_native_t native; + njs_function_t *func; njs_lvlhsh_t keys; njs_str_t match; @@ -391,6 +391,7 @@ njs_builtin_traverse(njs_vm_t *vm, njs_t u_char *p, *start, *end; njs_int_t ret, n; njs_str_t name; + njs_function_t *func; njs_object_prop_t *prop; njs_lvlhsh_query_t lhq; njs_builtin_traverse_t *ctx; @@ -401,10 +402,11 @@ njs_builtin_traverse(njs_vm_t *vm, njs_t if (ctx->type == NJS_BUILTIN_TRAVERSE_MATCH) { prop = traverse->prop; + func = ctx->func; if (!(njs_is_function(&prop->value) && njs_function(&prop->value)->native - && njs_function(&prop->value)->u.native == ctx->native)) + && njs_native_function_same(njs_function(&prop->value), func))) { return NJS_OK; } @@ -739,7 +741,7 @@ njs_object_completions(njs_vm_t *vm, njs njs_int_t -njs_builtin_match_native_function(njs_vm_t *vm, njs_function_native_t func, +njs_builtin_match_native_function(njs_vm_t *vm, njs_function_t *function, njs_str_t *name) { njs_int_t ret; @@ -750,7 +752,7 @@ njs_builtin_match_native_function(njs_vm njs_builtin_traverse_t ctx; ctx.type = NJS_BUILTIN_TRAVERSE_MATCH; - ctx.native = func; + ctx.func = function; /* Global object. */ diff -r 74c2de51636c -r b247b1c5531f src/njs_function.h --- a/src/njs_function.h Wed Jan 22 15:29:44 2020 +0300 +++ b/src/njs_function.h Wed Jan 22 15:29:47 2020 +0300 @@ -203,6 +203,13 @@ njs_function_apply(njs_vm_t *vm, njs_fun } +njs_inline njs_bool_t +njs_native_function_same(const njs_function_t *f1, const njs_function_t *f2) +{ + return f1->u.native == f2->u.native && f1->magic == f2->magic; +} + + extern const njs_object_type_init_t njs_function_type_init; extern const njs_object_init_t njs_function_instance_init; extern const njs_object_init_t njs_arrow_instance_init; diff -r 74c2de51636c -r b247b1c5531f src/njs_vm.c --- a/src/njs_vm.c Wed Jan 22 15:29:44 2020 +0300 +++ b/src/njs_vm.c Wed Jan 22 15:29:47 2020 +0300 @@ -991,8 +991,7 @@ njs_vm_add_backtrace_entry(njs_vm_t *vm, function = function->u.bound_target; } - ret = njs_builtin_match_native_function(vm, function->u.native, - &be->name); + ret = njs_builtin_match_native_function(vm, function, &be->name); if (ret == NJS_OK) { return NJS_OK; } diff -r 74c2de51636c -r b247b1c5531f src/njs_vm.h --- a/src/njs_vm.h Wed Jan 22 15:29:44 2020 +0300 +++ b/src/njs_vm.h Wed Jan 22 15:29:47 2020 +0300 @@ -302,7 +302,7 @@ njs_int_t njs_vm_backtrace_to_string(njs njs_int_t njs_builtin_objects_create(njs_vm_t *vm); njs_int_t njs_builtin_objects_clone(njs_vm_t *vm, njs_value_t *global); njs_int_t njs_builtin_match_native_function(njs_vm_t *vm, - njs_function_native_t func, njs_str_t *name); + njs_function_t *function, njs_str_t *name); njs_arr_t *njs_vm_completions(njs_vm_t *vm, njs_str_t *expression); diff -r 74c2de51636c -r b247b1c5531f src/test/njs_interactive_test.c --- a/src/test/njs_interactive_test.c Wed Jan 22 15:29:44 2020 +0300 +++ b/src/test/njs_interactive_test.c Wed Jan 22 15:29:47 2020 +0300 @@ -232,10 +232,15 @@ static njs_interactive_test_t njs_test[ " at f (:1)\n" " at main (native)\n") }, - { njs_str("var fs = require('fs'); fs.readFile()" ENTER), - njs_str("TypeError: \"path\" must be a string\n" - " at fs.readFile (native)\n" - " at main (native)\n") }, + { njs_str("var fs = require('fs');" + "['readFile'," + " 'readFileSync'," + " 'writeFile'," + " 'writeFileSync'," + " 'appendFile'," + " 'appendFileSync']" + ".every(v=>{ try {fs[v]();} catch (e) { return e.stack.search(`fs.${v} `) >= 0}})" ENTER), + njs_str("true") }, { njs_str("parseInt({ toString: function() { return [1] } })" ENTER), njs_str("TypeError: Cannot convert object to primitive value\n"

2 years, 10 months

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

nginx-devel January 2020