Hi,
I have a question related to internal redirect, I am hoping someone from
this forum can clarify. The email is a bit long since I wanted to provide
enough background for my situation.
In my module, I am creating my module context and saving some state. Some
of this state is allocated using ngx_palloc. I am releasing this memory by
adding a pool clean up handler.
In my module, for certain requests I am doing an internal redirect. My code
for redirect looks something like this:
ngx_http_internal_redirect(r, &new_uri, &r->args);
ngx_http_finalize_request(r, NGX_DONE);
According to the documentation
http://nginx.org/en/docs/dev/development_guide.html#http_request_redirection
it says, on calling internal_redirect, the module context will be erased to
avoid inconsistencies. It also says, the processing returns to the
NGX_HTTP_SERVER_REWRITE_PHASE. To understand the behavior better, I
attached a debugger and added a breakpoint after the above two lines. When
the debugger stopped at my breakpoint, my module context still seems to be
valid. I added a second breakpoint in my rewrite-handler and allowed the
debugger to continue. Now when the debugger stopped at the second
breakpoint, my module context was erased which seems consistent with the
documentation.
So my question is, if my context is erased, what happens to the memory I
allocated before my module invoked the internal redirect call? I put a log
statement in my cleanup function and I observed that it is getting invoked
only once at the end of the request processing. It is not getting called
when my context is erased after an internal redirect. Since I need my
context data after redirection, do I reallocate and recreate it? Since my
clean up code is getting called only once. Would this lead to a memory leak
if I reallocated after the internal redirect call because I'd be allocated
once before redirect and once after redirect. Any help or clarification in
this regard is greatly appreciated.
Dk.
details: https://hg.nginx.org/nginx/rev/5d88e2bf92b3
branches:
changeset: 7996:5d88e2bf92b3
user: Maxim Dounin <mdounin(a)mdounin.ru>
date: Sat Jan 22 00:28:51 2022 +0300
description:
Contrib: vim syntax adjusted to save cpoptions (ticket #2276).
Line continuation as used in the syntax file might be broken if "compatible"
is set or "C" is added to cpoptions. Fix is to set the "cpoptions" option
to vim default value at script start and restore it later, see
":help use-cpo-save".
diffstat:
contrib/vim/syntax/nginx.vim | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diffs (21 lines):
diff -r 7752d8523066 -r 5d88e2bf92b3 contrib/vim/syntax/nginx.vim
--- a/contrib/vim/syntax/nginx.vim Wed Jan 19 17:37:34 2022 -0800
+++ b/contrib/vim/syntax/nginx.vim Sat Jan 22 00:28:51 2022 +0300
@@ -5,6 +5,9 @@ if exists("b:current_syntax")
finish
end
+let s:save_cpo = &cpo
+set cpo&vim
+
" general syntax
if has("patch-7.4.1142")
@@ -2485,4 +2488,7 @@ hi def link ngxDirectiveThirdPartyDeprec
hi def link ngxListenOptions Keyword
hi def link ngxListenOptionsDeprecated Error
+let &cpo = s:save_cpo
+unlet s:save_cpo
+
let b:current_syntax = "nginx"
# HG changeset patch
# User Maxim Dounin <mdounin(a)mdounin.ru>
# Date 1642737110 -10800
# Fri Jan 21 06:51:50 2022 +0300
# Node ID cff51689a4a182cb11cba2eb9303e2bc21815432
# Parent 96ae8e57b3dd1b10f29d3060bbad93b7f9357b92
SSL: always renewing tickets with TLSv1.3 (ticket #1892).
Chrome only use TLS session tickets once with TLS 1.3, likely following
RFC 8446 Appendix C.4 recommendation. With OpenSSL, this works fine with
built-in session tickets, since these are explicitly renewed in case of
TLS 1.3 on each session reuse, but results in only two connections being
reused after an initial handshake when using ssl_session_ticket_key.
Fix is to always renew TLS session tickets in case of TLS 1.3 when using
ssl_session_ticket_key, similarly to how it is done by OpenSSL internally.
diff --git a/src/event/ngx_event_openssl.c b/src/event/ngx_event_openssl.c
--- a/src/event/ngx_event_openssl.c
+++ b/src/event/ngx_event_openssl.c
@@ -4448,7 +4448,21 @@ ngx_ssl_session_ticket_key_callback(ngx_
return -1;
}
- return (i == 0) ? 1 : 2 /* renew */;
+ /* renew if TLSv1.3 */
+
+#ifdef TLS1_3_VERSION
+ if (SSL_version(ssl_conn) == TLS1_3_VERSION) {
+ return 2;
+ }
+#endif
+
+ /* renew if non-default key */
+
+ if (i != 0) {
+ return 2;
+ }
+
+ return 1;
}
}