[PATCH] Fixing an obvious segfault in ngx_http_upstream

agentzh agentzh at gmail.com
Tue May 4 06:38:20 MSD 2010

On Tue, May 4, 2010 at 3:11 AM, Igor Sysoev <igor at sysoev.ru> wrote:
> You should test u->cleanup before *u->cleanup = NULL.
> This code has appeared in 0.8.33:

Hi, Igor,

It is *YOU* who didn't test u->cleanup before *u->cleanup in
ngx_http_upstream_create ;)

Please read my patch more carefully. To emphasize, in
ngx_http_upstream_create, the ngx_http_upstream_cleanup call first
clears u->cleanup but you later set *u->cleanup to NULL, which leads
to segfault.

There's no code written by myself, all in your nginx core ;)

I don't see how it is relevant to your fastcgi fixes in 0.8.33. This
bug appeared at least in nginx 0.8.29 :)


More information about the nginx-devel mailing list