it seems a bug in ngx_http_gzip_disable function.

[Igor Sysoev]

On Mon, Oct 11, 2010 at 12:55:50PM +0800, jin huang wrote:

> Hello everyone,
> 
> In ngx_http_gzip_disable function of http/ngx_http_core_module.c,
> The code is here:
> http://www.google.com/codesearch/p?hl=en#N6mCnE4lf5g/src/http/ngx_http_core_module.c&q=http_gzip_disable%20package:nginx&sa=N&cd=1&ct=rc&l=73Line
> 4387-4392:
> 
>     for (i = 1; i < cf->args->nelts; i++) {        if
> (ngx_strcmp(value[1].data, "msie6") == 0) {
> clcf->gzip_disable_msie6 = 1;            continue;        }
> 
> It used value[1] to compare with "msie6", which I think "1" is a misspell of
> "i". If it is indeed 1, then I think maybe the if statement should be
> located outside the for loop.
> 
> Thank you for taking the time to read.

Changes with nginx 0.8.50                                        02 Sep 2010

    *) Bugfix: in the "gzip_disable" directive.
       Thanks to Derrick Petzold.


-- 
Igor Sysoev
http://sysoev.ru/en/