[PATCH 0 of 5] cache patches

Maxim Dounin mdounin at mdounin.ru
Mon Dec 12 10:34:37 UTC 2011


Hello!

On Mon, Dec 12, 2011 at 10:25:34AM +0000, António P. P. Almeida wrote:

[...]

> > In the above scenario, request (2) will be served at t=700ms 
> > (500ms after request) and request (3) will be served at t=720ms.  
> > This is because right now requests use periodic timer (each 500ms) 
> > to see if response arrived.
> 
> Ok. This is harcoded right now, here I think:
> 
> +    if (wait) {
> +        ngx_add_timer(ev, (timer > 500) ? 500 : timer);
> +        return;
> +    }
> 
> Can we not make this a user defined setting? E.g.:
> 
> proxy_cache_lock_request_period <value ms>; # defaults to 500
> 
> I don't know if making this period user defined will have consequences
> down the line in other cache manager code.

This may be changed to user setting, but I don't want to as this 
is expected to move away from timer to event-based notification 
some day.

Maxim Dounin



More information about the nginx-devel mailing list