Fix nginx for build with any version of openssl.

Maxim Dounin mdounin at mdounin.ru
Tue Jan 11 03:10:23 MSK 2011


Hello!

On Mon, Jan 10, 2011 at 11:45:26PM +0300, Kirill A. Korinskiy wrote:

> Fix nginx for build with any version of openssl.
> 
> Format of openssl version is MNNFFPPS: major minor fix patch status
> The status nibble has one of the values 0 for development, 1 to e for betas
> 1 to 14, and f for release.  The patch level is exactly that.

Missing part in your patch comment is when the interface change in 
question ("const" qualifier in SSL_get_current_cipher()'s return 
type and other places) was introduced.

It was introduced here:

http://cvs.openssl.org/chngview?cn=17503
2008-Oct-12 14:32:38 (UTC)

at that time version in openssl's HEAD was 0x00909000L, and it was 
bumped to 0x10000000L here:

http://cvs.openssl.org/chngview?cn=17927
2009-Mar-28 17:12:50 (UTC)

There were no version bump for the interface change in question, 
so you really can't make nginx buildable with *any* version with 
this aproach.  Though checking for 0x10000000L is indeed ok, it 
will make nginx buildable with openssl 1.0.0-beta[12345] without 
breaking anything.

Maxim Dounin



More information about the nginx-devel mailing list