[PATCH] GeoIP module: UTF-8 support in city names

Denis F. Latypoff latypoff at yandex.ru
Thu Jan 27 13:33:30 MSK 2011


27.01.2011, 13:26, "Igor Sysoev" <igor at sysoev.ru>:
> On Thu, Jan 27, 2011 at 01:19:36PM +0300, Denis F. Latypoff wrote:
>
>>  Hello, by default GeoIP returns ISO-8859-1 encoded city names which
>>  is not suitable sometimes (e.g varchar utf8 in the DB may cause broken
>>  names, etc). So attached patch allows to use UTF-8 in city names.
>
> May be, it's better to use UTF-8 always ?
> Will it break current non-UTF-8 setups ?

I'd prefer UTF-8 by default, but yes it will break current setup.
People might used special decoders from latin1 to utf-8, so
default utf-8 may break behavior.

-- 
br, Denis F. Latypoff.



More information about the nginx-devel mailing list