[PATCH] Ignore response header entries with zero hash in ngx_http_varaible_headers

agentzh agentzh at gmail.com
Fri Sep 30 18:08:36 UTC 2011

On Fri, Sep 30, 2011 at 9:05 AM, Maxim Dounin <mdounin at mdounin.ru> wrote:
> It looks like this particular case affects
> $sent_http_cache_control only.

It seems :)

> Though it looks like similar issue exists in
> ngx_http_variable_unknown_header(), it should be fixed
> too.  Quick look suggests in vanilla nginx it may affect
> $sent_http_accept_ranges, $sent_http_refresh,
> $sent_http_www_authenticate and probably other headers.

Indeed, this one affects user custom response headers too :)

> Could you please take a closer look and provide patch which fixes
> this one too?

Sure. The fix is already included in the updated version of my patch
attached to this email.

> And see below for review.

Thank you for the review. I've already updated the patch per your
suggestion and tested on my side :)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: nginx-1.1.4-variable_headers_ignore_no_hash_v2.patch
Type: application/octet-stream
Size: 1441 bytes
Desc: not available
URL: <http://mailman.nginx.org/pipermail/nginx-devel/attachments/20110930/48e21a7b/attachment.obj>

More information about the nginx-devel mailing list