[nginx] svn commit: r4812 - trunk/src/http/modules

magic.drums at gmail.com magic.drums at gmail.com
Sun Aug 12 05:34:57 UTC 2012


If they were 10 commits not worry is not so much for the entire amount
already received but when there are more prefer to make a compiled and sent
on to the end of the day.

regards

On Sun, Aug 12, 2012 at 1:29 AM, thinkee365 <thinke365 at gmail.com> wrote:

>
>
> why svn commit is send to maillist?
> it that necessary?
> if there are 10 commit to svn per day, then the subscriber of nginx maybe
> receive 10 mails:(
>
>
> On Wed, Aug 08, 2012 at 12:03:47PM +0000, vbart at nginx.com wrote:
> > Author: vbart
> > Date: 2012-08-08 12:03:46 +0000 (Wed, 08 Aug 2012)
> > New Revision: 4812
> > URL: http://trac.nginx.org/nginx/changeset/4812/nginx
> >
> > Log:
> > Added three missing checks for NULL after ngx_array_push() calls.
> >
> > Found by Coverity.
> >
> >
> > Modified:
> >    trunk/src/http/modules/ngx_http_fastcgi_module.c
> >    trunk/src/http/modules/ngx_http_limit_conn_module.c
> >    trunk/src/http/modules/ngx_http_limit_req_module.c
> >
> > Modified: trunk/src/http/modules/ngx_http_fastcgi_module.c
> > ===================================================================
> > --- trunk/src/http/modules/ngx_http_fastcgi_module.c  2012-08-07
> 13:57:04 UTC (rev 4811)
> > +++ trunk/src/http/modules/ngx_http_fastcgi_module.c  2012-08-08
> 12:03:46 UTC (rev 4812)
> > @@ -1626,6 +1626,9 @@
> >          }
> >
> >          part = ngx_array_push(f->split_parts);
> > +        if (part == NULL) {
> > +            return NGX_ERROR;
> > +        }
> >
> >          part->start = part_start;
> >          part->end = part_end;
> >
> > Modified: trunk/src/http/modules/ngx_http_limit_conn_module.c
> > ===================================================================
> > --- trunk/src/http/modules/ngx_http_limit_conn_module.c       2012-08-07
> 13:57:04 UTC (rev 4811)
> > +++ trunk/src/http/modules/ngx_http_limit_conn_module.c       2012-08-08
> 12:03:46 UTC (rev 4812)
> > @@ -721,6 +721,10 @@
> >      }
> >
> >      limit = ngx_array_push(&lccf->limits);
> > +    if (limit == NULL) {
> > +        return NGX_CONF_ERROR;
> > +    }
> > +
> >      limit->conn = n;
> >      limit->shm_zone = shm_zone;
> >
> >
> > Modified: trunk/src/http/modules/ngx_http_limit_req_module.c
> > ===================================================================
> > --- trunk/src/http/modules/ngx_http_limit_req_module.c        2012-08-07
> 13:57:04 UTC (rev 4811)
> > +++ trunk/src/http/modules/ngx_http_limit_req_module.c        2012-08-08
> 12:03:46 UTC (rev 4812)
> > @@ -937,6 +937,9 @@
> >      }
> >
> >      limit = ngx_array_push(&lrcf->limits);
> > +    if (limit == NULL) {
> > +        return NGX_CONF_ERROR;
> > +    }
> >
> >      limit->shm_zone = shm_zone;
> >      limit->burst = burst * 1000;
> >
> > _______________________________________________
> > nginx-devel mailing list
> > nginx-devel at nginx.org
> > http://mailman.nginx.org/mailman/listinfo/nginx-devel
>
> _______________________________________________
> nginx-devel mailing list
> nginx-devel at nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>



-- 
Victor Pereira
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.nginx.org/pipermail/nginx-devel/attachments/20120812/65031682/attachment.html>


More information about the nginx-devel mailing list