[nginx] svn commit: r4547 - trunk/src/http

maxim at nginx.com maxim at nginx.com
Mon Mar 19 14:57:30 UTC 2012


Author: maxim
Date: 2012-03-19 14:57:29 +0000 (Mon, 19 Mar 2012)
New Revision: 4547

Log:
For the sake of case/switch code readability, 'fall through'
comments added.


Modified:
   trunk/src/http/ngx_http_parse.c
   trunk/src/http/ngx_http_upstream.c

Modified: trunk/src/http/ngx_http_parse.c
===================================================================
--- trunk/src/http/ngx_http_parse.c	2012-03-16 19:15:33 UTC (rev 4546)
+++ trunk/src/http/ngx_http_parse.c	2012-03-19 14:57:29 UTC (rev 4547)
@@ -1153,6 +1153,7 @@
                 break;
             case '+':
                 r->plus_in_uri = 1;
+                /* fall through */
             default:
                 *u++ = ch;
                 break;

Modified: trunk/src/http/ngx_http_upstream.c
===================================================================
--- trunk/src/http/ngx_http_upstream.c	2012-03-16 19:15:33 UTC (rev 4546)
+++ trunk/src/http/ngx_http_upstream.c	2012-03-19 14:57:29 UTC (rev 4547)
@@ -3312,6 +3312,8 @@
         switch (n) {
         case 0:
             u->cacheable = 0;
+            /* fall through */
+
         case NGX_ERROR:
             return NGX_OK;
 
@@ -4460,6 +4462,8 @@
     case NGX_DECLINED:
         ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
                            "invalid address \"%V\"", &value[1]);
+        /* fall through */
+
     default:
         return NGX_CONF_ERROR;
     }



More information about the nginx-devel mailing list