HTML parsing support for xslt module

Maxim Dounin mdounin at mdounin.ru
Wed Mar 21 14:31:43 UTC 2012


Hello!

On Wed, Mar 21, 2012 at 01:55:09PM +0000, Laurence Rowe wrote:

> Snipping for brevity:
> 
> On 21 March 2012 12:55, Maxim Dounin <mdounin at mdounin.ru> wrote:
> >> > 2) The are no error handling for html code, and while it's
> >> > probably ok to ignore parsing problems - it's certainly not ok to
> >> > ignore fatal problems like memory allocation ones.
> >>
> >> I'll add back the fatal error handler and add an off switch to it.
> >
> > Not really understand.  Why do you think it should be possible to
> > switch off handling of memory allocation errors?
> 
> I wasn't clear here. Currently errors are detected with the return
> value from xmlParseChunk. With htmlParseChunk we cannot use the return
> value as we want to ignore any recoverable parsing errors, so we need
> another way to detect when a fatal error has occurred. I'll add a flag
> (or 'off switch') to ngx_http_xslt_filter_ctx_t, set it in
> ngx_http_xslt_sax_error when an error and test that instead.

Ok, this looks fine.  Thanks for clarification.

Maxim Dounin



More information about the nginx-devel mailing list