[PATCH] SPDY: fix nopush cleanup

[Valentin V. Bartenev]

On Tuesday 11 June 2013 19:30:08 Yury Kirpichev wrote:
> Hello,
> 
> Thanks for your comments.
> How about second version:
> 
> # HG changeset patch
> # User ykirpichev at gmail.com
> # Date 1370964275 -14400
> # Branch nopush_fix_2
> # Node ID 14de55787a48327019d549d48abf2631e294b4d8
> # Parent  725fb71ab1a60bd48b0afb8b001b5349f5054cb1
> SPDY: fix nopush cleanup
> 
> diff -r 725fb71ab1a6 -r 14de55787a48 src/http/ngx_http_spdy.c
> --- a/src/http/ngx_http_spdy.c  Fri Jun 07 13:16:00 2013 -0700
> +++ b/src/http/ngx_http_spdy.c  Tue Jun 11 19:24:35 2013 +0400
> @@ -504,6 +504,51 @@
>      clcf = ngx_http_get_module_loc_conf(sc->http_connection->conf_ctx,
>                                          ngx_http_core_module);
> 
> +    // all data is sent, can clean nopush if necessary
> +    if (wev->ready)
> +    {
[...]

No, it doesn't indicate that there is no data to send even in a short term.

  wbr, Valentin V. Bartenev