[nginx] Proxy: clear script engine used to calculate lengths.

Maxim Dounin mdounin at mdounin.ru
Wed May 15 09:21:41 UTC 2013


details:   http://hg.nginx.org/nginx/rev/ecd762770729
branches:  
changeset: 5211:ecd762770729
user:      Maxim Dounin <mdounin at mdounin.ru>
date:      Wed May 15 12:23:44 2013 +0400
description:
Proxy: clear script engine used to calculate lengths.

Previous code is believed to be safe, but might access uninitialized
memory (e.g., e->quote).

diffstat:

 src/http/modules/ngx_http_proxy_module.c |  2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diffs (12 lines):

diff --git a/src/http/modules/ngx_http_proxy_module.c b/src/http/modules/ngx_http_proxy_module.c
--- a/src/http/modules/ngx_http_proxy_module.c
+++ b/src/http/modules/ngx_http_proxy_module.c
@@ -993,6 +993,8 @@ ngx_http_proxy_create_request(ngx_http_r
 
     len += uri_len;
 
+    ngx_memzero(&le, sizeof(ngx_http_script_engine_t));
+
     ngx_http_script_flush_no_cacheable_variables(r, plcf->flushes);
 
     if (plcf->body_set_len) {



More information about the nginx-devel mailing list