[nginx] SSL: fixed possible memory and file descriptor leak on H...

Maxim Dounin mdounin at mdounin.ru
Thu Sep 19 13:26:25 UTC 2013


details:   http://hg.nginx.org/nginx/rev/cfbf1d1cc233
branches:  
changeset: 5384:cfbf1d1cc233
user:      Piotr Sikora <piotr at cloudflare.com>
date:      Wed Sep 18 16:51:30 2013 -0700
description:
SSL: fixed possible memory and file descriptor leak on HUP signal.

The problem appeared in 386a06a22c40 (1.3.7).

Signed-off-by: Piotr Sikora <piotr at cloudflare.com>

diffstat:

 src/event/ngx_event_openssl.c |  2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diffs (12 lines):

diff --git a/src/event/ngx_event_openssl.c b/src/event/ngx_event_openssl.c
--- a/src/event/ngx_event_openssl.c
+++ b/src/event/ngx_event_openssl.c
@@ -280,6 +280,8 @@ ngx_ssl_certificate(ngx_conf_t *cf, ngx_
     {
         ngx_ssl_error(NGX_LOG_EMERG, ssl->log, 0,
                       "SSL_CTX_set_ex_data() failed");
+        X509_free(x509);
+        BIO_free(bio);
         return NGX_ERROR;
     }
 



More information about the nginx-devel mailing list