[PATCH] Proxy: added the "proxy_ssl_ciphers" directive.

Maxim Dounin mdounin at mdounin.ru
Wed Sep 25 12:43:53 UTC 2013


Hello!

On Tue, Sep 24, 2013 at 05:02:45PM -0700, Piotr Sikora wrote:

> Hi Maxim,
> 
> >> +#define NGX_DEFAULT_CIPHERS  "DEFAULT"
> >> +
> >> +
> >
> > I tend to think it would be better to omit this for clarity, and
> > just use the "DEFAULT" string constant in
> > ngx_conf_merge_str_value():
> >
> > (...)
> >
> > You are ok with this?  If yes, I'll just push the fixed version.
> 
> I think that's more consistent with ngx_{mail,http}_ssl_module this
> way, but I don't feel strongly about it, so feel free to commit your
> version... I won't mind :)

I don't like the idea of NGX_DEFAULT_CIPHERS being defined into 
different strings in different modules, hence the difference with 
ngx_mail_ssl_module/ngx_http_ssl_module looks reasonable for me.

Committed, thanks.

-- 
Maxim Dounin
http://nginx.org/en/donation.html



More information about the nginx-devel mailing list