[nginx] Fixed ngx_http_test_reading() to finalize request properly.

[SplitIce]

I know this patch was made for 1.5.x however I patched our 1.4.x build
(internal modules are in the process of being upgraded currently). However
I am still getting 000 in the logs. I am currently crawling the change logs
for similar patches.

Any chance you can remember any similar issue being resolved in the 1.5.x
branch?

Thanks,
Mathew


On Thu, Jul 25, 2013 at 9:28 PM, Maxim Dounin <mdounin at mdounin.ru> wrote:

> details:   http://hg.nginx.org/nginx/rev/aadfadd5af2b
> branches:
> changeset: 5289:aadfadd5af2b
> user:      Maxim Dounin <mdounin at mdounin.ru>
> date:      Fri Jun 14 20:56:07 2013 +0400
> description:
> Fixed ngx_http_test_reading() to finalize request properly.
>
> Previous code called ngx_http_finalize_request() with rc = 0.  This is
> ok if a response status was already set, but resulted in "000" being
> logged if it wasn't.  In particular this happened with limit_req
> if a connection was prematurely closed during limit_req delay.
>
> diffstat:
>
>  src/http/ngx_http_request.c |  2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diffs (12 lines):
>
> diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c
> --- a/src/http/ngx_http_request.c
> +++ b/src/http/ngx_http_request.c
> @@ -2733,7 +2733,7 @@ closed:
>      ngx_log_error(NGX_LOG_INFO, c->log, err,
>                    "client prematurely closed connection");
>
> -    ngx_http_finalize_request(r, 0);
> +    ngx_http_finalize_request(r, NGX_HTTP_CLIENT_CLOSED_REQUEST);
>  }
>
>
>
> _______________________________________________
> nginx-devel mailing list
> nginx-devel at nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.nginx.org/pipermail/nginx-devel/attachments/20130928/33299020/attachment.html>