[nginx] SPDY: better detect premature closing of stream.

Valentin Bartenev vbart at nginx.com
Mon Apr 7 15:29:26 UTC 2014


details:   http://hg.nginx.org/nginx/rev/0aeb6f63d242
branches:  
changeset: 5641:0aeb6f63d242
user:      Valentin Bartenev <vbart at nginx.com>
date:      Mon Apr 07 19:27:56 2014 +0400
description:
SPDY: better detect premature closing of stream.

Following a24f88eff684, now the case when the FIN flag is set in SYN_STREAM
is also covered.

diffstat:

 src/http/ngx_http_spdy.c |  10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diffs (20 lines):

diff -r 4c6ceca4f5f7 -r 0aeb6f63d242 src/http/ngx_http_spdy.c
--- a/src/http/ngx_http_spdy.c	Mon Apr 07 18:55:57 2014 +0400
+++ b/src/http/ngx_http_spdy.c	Mon Apr 07 19:27:56 2014 +0400
@@ -2962,6 +2962,16 @@ ngx_http_spdy_run_request(ngx_http_reque
         return;
     }
 
+    if (r->headers_in.content_length_n > 0 && r->spdy_stream->in_closed) {
+        ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
+                      "client prematurely closed stream");
+
+        r->spdy_stream->skip_data = NGX_SPDY_DATA_ERROR;
+
+        ngx_http_finalize_request(r, NGX_HTTP_BAD_REQUEST);
+        return;
+    }
+
     ngx_http_process_request(r);
 }
 



More information about the nginx-devel mailing list