[nginx] Core: fixed error handling in ngx_reopen_files().

Maxim Dounin mdounin at mdounin.ru
Wed Apr 30 15:18:17 UTC 2014


details:   http://hg.nginx.org/nginx/rev/dfb3c15bc851
branches:  
changeset: 5680:dfb3c15bc851
user:      Maxim Dounin <mdounin at mdounin.ru>
date:      Wed Apr 30 19:16:40 2014 +0400
description:
Core: fixed error handling in ngx_reopen_files().

Found by Coverity (CID 1087509).

diffstat:

 src/core/ngx_cycle.c |  6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diffs (30 lines):

diff --git a/src/core/ngx_cycle.c b/src/core/ngx_cycle.c
--- a/src/core/ngx_cycle.c
+++ b/src/core/ngx_cycle.c
@@ -1104,6 +1104,8 @@ ngx_reopen_files(ngx_cycle_t *cycle, ngx
                                   ngx_close_file_n " \"%s\" failed",
                                   file[i].name.data);
                 }
+
+                continue;
             }
 
             if (fi.st_uid != user) {
@@ -1117,6 +1119,8 @@ ngx_reopen_files(ngx_cycle_t *cycle, ngx
                                       ngx_close_file_n " \"%s\" failed",
                                       file[i].name.data);
                     }
+
+                    continue;
                 }
             }
 
@@ -1133,6 +1137,8 @@ ngx_reopen_files(ngx_cycle_t *cycle, ngx
                                       ngx_close_file_n " \"%s\" failed",
                                       file[i].name.data);
                     }
+
+                    continue;
                 }
             }
         }



More information about the nginx-devel mailing list