[PATCH]Dav: ngx_http_map_uri_to_path() errors were not checked.

Maxim Dounin mdounin at mdounin.ru
Fri Aug 1 03:35:36 UTC 2014


Hello!

On Wed, Jul 30, 2014 at 02:58:04PM +0800, flygoast wrote:

> # HG changeset patch
> # User FengGu <flygoast at 126.com>
> # Date 1406702708 -28800
> #      Wed Jul 30 14:45:08 2014 +0800
> # Node ID 9a9f7c2783b1afe0e5d374450daa5df6acbfd332
> # Parent  4d092aa2f4637ce50284d2accd99a8e91aae2b4c
> Dav: ngx_http_map_uri_to_path() errors were not checked.
> 
> 
> Once error occured, it could lead to use uninitialized variables to log,
> even more segmentation fault.

Committed, thanks.

> diff -r 4d092aa2f463 -r 9a9f7c2783b1 src/http/modules/ngx_http_dav_module.c
> --- a/src/http/modules/ngx_http_dav_module.cMon Jul 28 12:27:57 2014 -0700
> +++ b/src/http/modules/ngx_http_dav_module.cWed Jul 30 14:45:08 2014 +0800
> @@ -212,7 +212,10 @@
>          return;
>      }

Two minor notes:

- Please post patches in plain text.  I had to recover text corruption 
  done by your mail client to commit it.

- Please add 

  [diff]
  showfunc=1

  to your ~/.hgrc.  This makes patches easier for review.

-- 
Maxim Dounin
http://nginx.org/



More information about the nginx-devel mailing list