[PATCH-REQUEST] : SPDY handling for 304 response

Shrirang Ballal sballal at instartlogic.com
Fri Dec 26 08:28:07 UTC 2014


I am very sorry for bringing this up.

This was a private change done in the private nginx that I was working on
and I mistakenly thought that this piece of code was in standard nginx.
I'll be more diligent next time onwards.

On Thu, Dec 25, 2014 at 9:00 PM, Valentin V. Bartenev <vbart at nginx.com>
wrote:

> On Thursday 25 December 2014 20:48:41 Shrirang Ballal wrote:
> > Hello Valentin,
> >
> > I understand that the "*complete*" handling of the 204 & 304 response is
> > not same, but it is same for below mentioned response headers received by
> > downstream client
> >
> > Quote for handling of "Content-Type", "Content-Length", "Last-Modified"
> > header from ngx_http_header_filter_module.c::ngx_http_header_filter()
> >     /* clear out CL/CT header for header only 204/304 response
> >        earlier it was done only for 204/304 generated by nginx
> >        making it common for both paths - when nginx is serving the
> response
> >        and when the response is generated from the upstream */
> >     if (r->headers_out.status == NGX_HTTP_NO_CONTENT
> >         || r->headers_out.status == NGX_HTTP_NOT_MODIFIED) {
> >       r->header_only = 1;
> >       ngx_str_null(&r->headers_out.content_type);
> >       r->headers_out.last_modified_time = -1;
> >       r->headers_out.last_modified = NULL;
> >       r->headers_out.content_length = NULL;
> >       r->headers_out.content_length_n = -1;
> >     }
> >
> > ---
>
> Where have you found this code?  It's not part of nginx.
>
>   wbr, Valentin V. Bartenev
>
> _______________________________________________
> nginx-devel mailing list
> nginx-devel at nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.nginx.org/pipermail/nginx-devel/attachments/20141226/60523bec/attachment.html>


More information about the nginx-devel mailing list