[PATCH] Use ngx_socket_errno where appropriate.

Maxim Dounin mdounin at mdounin.ru
Mon Feb 3 13:04:44 UTC 2014


On Fri, Jan 31, 2014 at 12:52:05PM -0800, Piotr Sikora wrote:

> Hey,
> I agree with Maxim, there is no reason to limit the use of
> ngx_socket_errno only to the cross-platform code.

Note that I still agree with Ruslan's comments to your patch, use 
of ngx_socket_errno to check errors from ioctl() / fcntl() in 
unix-specific code looks unneeded.  And in case of eventfd - it 
looks certainly wrong, as eventfd isn't a socket.

I would rather drop most of the src/os/unix changes, probably with 
the exception of ngx_tcp_nopush() checks.

Maxim Dounin

More information about the nginx-devel mailing list