[nginx] SPDY: better name for flag that indicates incomplete fra...

Valentin Bartenev vbart at nginx.com
Tue Jan 14 12:58:00 UTC 2014


details:   http://hg.nginx.org/nginx/rev/877a7bd72070
branches:  
changeset: 5509:877a7bd72070
user:      Valentin Bartenev <vbart at nginx.com>
date:      Tue Jan 14 16:24:45 2014 +0400
description:
SPDY: better name for flag that indicates incomplete frame state.

No functional changes.

diffstat:

 src/http/ngx_http_spdy.c |  8 ++++----
 src/http/ngx_http_spdy.h |  2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diffs (51 lines):

diff -r 9053fdcea4b7 -r 877a7bd72070 src/http/ngx_http_spdy.c
--- a/src/http/ngx_http_spdy.c	Tue Jan 14 16:24:45 2014 +0400
+++ b/src/http/ngx_http_spdy.c	Tue Jan 14 16:24:45 2014 +0400
@@ -346,7 +346,7 @@ ngx_http_spdy_read_handler(ngx_event_t *
             break;
         }
 
-        if (n == 0 && (sc->waiting || sc->processing)) {
+        if (n == 0 && (sc->incomplete || sc->processing)) {
             ngx_log_error(NGX_LOG_INFO, c->log, 0,
                           "client closed prematurely connection");
         }
@@ -360,7 +360,7 @@ ngx_http_spdy_read_handler(ngx_event_t *
         end += n;
 
         sc->buffer_used = 0;
-        sc->waiting = 0;
+        sc->incomplete = 0;
 
         do {
             p = sc->handler(sc, p, end);
@@ -567,7 +567,7 @@ ngx_http_spdy_handle_connection(ngx_http
 
     sscf = ngx_http_get_module_srv_conf(sc->http_connection->conf_ctx,
                                         ngx_http_spdy_module);
-    if (sc->waiting) {
+    if (sc->incomplete) {
         ngx_add_timer(c->read, sscf->recv_timeout);
         return;
     }
@@ -1489,7 +1489,7 @@ ngx_http_spdy_state_save(ngx_http_spdy_c
 
     sc->buffer_used = end - pos;
     sc->handler = handler;
-    sc->waiting = 1;
+    sc->incomplete = 1;
 
     return end;
 }
diff -r 9053fdcea4b7 -r 877a7bd72070 src/http/ngx_http_spdy.h
--- a/src/http/ngx_http_spdy.h	Tue Jan 14 16:24:45 2014 +0400
+++ b/src/http/ngx_http_spdy.h	Tue Jan 14 16:24:45 2014 +0400
@@ -107,7 +107,7 @@ struct ngx_http_spdy_connection_s {
     ngx_uint_t                       last_sid;
 
     unsigned                         blocked:1;
-    unsigned                         waiting:1; /* FIXME better name */
+    unsigned                         incomplete:1;
 };
 
 



More information about the nginx-devel mailing list