[nginx] SPDY: fixed build, broken by b7ee1bae0ffa.

Valentin Bartenev vbart at nginx.com
Tue Jan 14 23:25:32 UTC 2014


details:   http://hg.nginx.org/nginx/rev/439d05a037a3
branches:  
changeset: 5516:439d05a037a3
user:      Valentin Bartenev <vbart at nginx.com>
date:      Wed Jan 15 01:44:52 2014 +0400
description:
SPDY: fixed build, broken by b7ee1bae0ffa.

False positive warning about the "cl" variable may be uninitialized in
the ngx_http_spdy_filter_get_data_frame() call was suppressed.

It is always initialized either in the "while" cycle or in the following
"if" condition since frame_size cannot be zero.

diffstat:

 src/http/ngx_http_spdy_filter_module.c |  4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diffs (14 lines):

diff -r e5fb14e85040 -r 439d05a037a3 src/http/ngx_http_spdy_filter_module.c
--- a/src/http/ngx_http_spdy_filter_module.c	Tue Jan 14 16:24:45 2014 +0400
+++ b/src/http/ngx_http_spdy_filter_module.c	Wed Jan 15 01:44:52 2014 +0400
@@ -665,6 +665,10 @@ ngx_http_spdy_send_chain(ngx_connection_
         offset = 0;
     }
 
+#if (NGX_SUPPRESS_WARN)
+    cl = NULL;
+#endif
+
     slcf = ngx_http_get_module_loc_conf(r, ngx_http_spdy_module);
 
     frame_size = (limit && limit <= (off_t) slcf->chunk_size)



More information about the nginx-devel mailing list