[nginx] SPDY: fix support for headers with multiple values.

Valentin Bartenev vbart at nginx.com
Wed Jul 9 07:59:42 UTC 2014


details:   http://hg.nginx.org/nginx/rev/b522d5b137fd
branches:  
changeset: 5762:b522d5b137fd
user:      Piotr Sikora <piotr at cloudflare.com>
date:      Tue Jul 08 02:17:44 2014 -0700
description:
SPDY: fix support for headers with multiple values.

Split SPDY header with multiple, NULL-separated values:

    cookie: foo\0bar

into two separate HTTP headers with the same name:

    cookie: foo
    cookie: bar

Even though the logic for this behavior already existed
in the source code, it doesn't look that it ever worked
and SPDY streams with such headers were simply rejected.

Signed-off-by: Piotr Sikora <piotr at cloudflare.com>

diffstat:

 src/http/ngx_http_spdy.c |  2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diffs (12 lines):

diff -r 1d693deab8ae -r b522d5b137fd src/http/ngx_http_spdy.c
--- a/src/http/ngx_http_spdy.c	Tue Jul 08 03:03:14 2014 -0700
+++ b/src/http/ngx_http_spdy.c	Tue Jul 08 02:17:44 2014 -0700
@@ -2584,6 +2584,8 @@ ngx_http_spdy_parse_header(ngx_http_requ
                 r->header_end = p;
                 r->header_in->pos = p + 1;
 
+                r->state = sw_value;
+
                 return NGX_OK;
             }
 



More information about the nginx-devel mailing list