[PATCH] Access log: fix default value, broken by cb308813b453

Ruslan Ermilov ru at nginx.com
Tue Jun 3 20:38:47 UTC 2014


On Tue, Jun 03, 2014 at 10:54:49AM -0700, Piotr Sikora wrote:
> # HG changeset patch
> # User Piotr Sikora <piotr at cloudflare.com>
> # Date 1401818028 25200
> #      Tue Jun 03 10:53:48 2014 -0700
> # Node ID 7f425d67f91ae3966b4f31b33dcd0386977a97a4
> # Parent  c46657e391a3710c4ea20f312d46ff6566d80aef
> Access log: fix default value, broken by cb308813b453.
> 
> log->filter ("if" parameter) was uninitialized when the default value
> was being used, which would lead to a crash (SIGSEGV) when access_log
> directive wasn't specified in the configuration.
> 
> Zero-fill the whole structure instead of zeroing fields one-by-one
> in order to prevent similar issues in the future.
> 
> Signed-off-by: Piotr Sikora <piotr at cloudflare.com>

Looks good.



More information about the nginx-devel mailing list