[PATCH] Core: use uppercase hexadecimal digits for percent-encoding

Piotr Sikora piotr at cloudflare.com
Mon Jun 30 21:01:30 UTC 2014


Hey Maxim,

> I can't say I like this change.  I've considered this a while ago,
> and decided to keep it as is.  This preserve compatibility with
> what nginx used to do for years.  And it also looks like Apache
> does the same.
>
> Any other opinions?

Compatibility for whom? This change is transparent for decoders
(upper- and lowercase hex digits are equivalent, per RFC) and, as far
as I can tell, it only affects people who try to encode URLs to match
what nginx produces and/or do case-sensitive matching (like
nginx-tests/autoindex.t).

The code in both: nginx and Apache predates RFC, which explains why it
wasn't uppercase from the beginning, but since RFC is out, there is no
good reason for keeping it this way.

Best regards,
Piotr Sikora



More information about the nginx-devel mailing list