[PATCH] Parse: underscores_in_headers should apply to the first character as well
Maxim Dounin
mdounin at mdounin.ru
Tue Mar 25 16:15:33 UTC 2014
Hello!
On Mon, Mar 24, 2014 at 04:48:29PM -0700, Piotr Sikora wrote:
> Hey Maxim,
>
> > - the "Parse:" prefix isn't something we use, it may be good idea
> > to avoid id;
>
> Done.
>
> > - please keep summary line short to avoid "hg log" wrapping, see
> > http://nginx.org/en/docs/contributing_changes.html;
>
> Done.
>
> > - is it something really needed in practice?
>
> Well, I'm not a fan of allowing underscores in the headers in the
> first place, but since this is already in nginx, I don't see a reason
> why this directive should allow underscores anywhere in the header
> name, but not in the first character...
>
> And yes, we have customers proxying headers starting with an underscore.
[...]
Committed, thanks.
--
Maxim Dounin
http://nginx.org/
More information about the nginx-devel
mailing list