[PATCH 2 of 2] auto/feature: disable feature autotest when cross-compiling

Maxim Dounin mdounin at mdounin.ru
Fri May 9 04:04:43 UTC 2014


Hello!

On Sun, May 04, 2014 at 08:08:30AM +0200, Samuel Martin wrote:

> # HG changeset patch
> # User Samuel Martin <s.martin49 at gmail.com>
> # Date 1399156849 -7200
> #      Sun May 04 00:40:49 2014 +0200
> # Node ID 03617a96c528d1f02abf829df964fcb29b06c942
> # Parent  f0f3f5208b12c6afbbdfb55b32c968ebd7206ad5
> auto/feature: disable feature autotest when cross-compiling
> 
> This patch introduce a new NGX_CROSSBUILD configure variable that records
> whether --crossbuild=... option was passed on the command line.
> 
> Then this variable is used to disable the feature runtest because they
> cannot usually be executed when cross-compiling.

No.

This is very bad approach, as it silently assumes that every test 
which can be compiled succeeds.

Not to mention that is't just wrong for "value" and "bug" tests.

-- 
Maxim Dounin
http://nginx.org/



More information about the nginx-devel mailing list