[PATCH] append "-gzip" to etags processed by gzip_filter_module + not modified support

Andrew Williams sobakasu at gmail.com
Fri May 30 02:25:40 UTC 2014


Hi,

> On Wed, May 28, 2014 at 04:26:04PM +0930, Andrew Williams wrote:
>
>> this patch modifies the etag header returned by responses processed by
>> the gzip filter, appending "-gzip" to the etag (instead of deleting
>> it). Also, If-None-Match and If-Match requests work against the
>> modified etag.
>> (the gunzip module appends "-gunzip" to the etag).
>
> This approach is wrong, as resources with the same etag are not
> guaranteed to be equal.

thanks for the feedback - only stripping strong etags looks like a
good solution. looking forward to seeing the weak etag code making it
in.
cheers
Andrew



More information about the nginx-devel mailing list