[PATCH] Upstream: fixed $upstream_response_time for filter_finalize + error_page.

Yichun Zhang (agentzh) agentzh at gmail.com
Mon Mar 2 19:37:33 UTC 2015

Hi Maxim

On Mon, Mar 2, 2015 at 11:09 AM, Maxim Dounin wrote:
> I've committed this and another patch related to filter
> finalization, see here:
> http://hg.nginx.org/nginx/rev/5abf5af257a7
> http://hg.nginx.org/nginx/rev/5f179f344096

Great. Thanks!

> In the particular case you've described in the commit log of your
> patch, I would also recommend to avoid using filter finalization.
> When in header filter, it should be enough to just return
> appropriate code instead.  Filter finalization is needed when
> working with a response body, not headers.

Oh I was not aware of that. Thanks for the suggestion and
clarification! I'll adjust my module code accordingly :)


More information about the nginx-devel mailing list