[PATCH] Core: detect valid error numbers at run-time

[Maxim Dounin]

Hello!

On Fri, Jul 01, 2016 at 02:31:41PM -0700, Piotr Sikora wrote:

> # HG changeset patch
> # User Piotr Sikora <piotrsikora at google.com>
> # Date 1467064814 25200
> #      Mon Jun 27 15:00:14 2016 -0700
> # Node ID be7eadea3d089f18c5ea685c09824ddcd99c3fe5
> # Parent  d452cb27639f714bc43b7f3ede417e3e7f8efdd6
> Core: detect valid error numbers at run-time.
> 
> Strings for some error numbers might be omitted, at least on Linux,
> so stop after 3 unknown errors in a row and not after the first one.
> 
> Signed-off-by: Piotr Sikora <piotrsikora at google.com>
> 
> diff -r d452cb27639f -r be7eadea3d08 auto/unix
> --- a/auto/unix
> +++ b/auto/unix
> @@ -697,60 +697,6 @@ ngx_feature_test="char buf[1]; struct io
>  . auto/feature
>  
>  
> -ngx_feature="sys_nerr"
> -ngx_feature_name="NGX_SYS_NERR"
> -ngx_feature_run=value
> -ngx_feature_incs='#include <errno.h>
> -                  #include <stdio.h>'
> -ngx_feature_path=
> -ngx_feature_libs=
> -ngx_feature_test='printf("%d", sys_nerr);'
> -. auto/feature

This looks utterly wrong.  You are removing proper support for 
platforms with sys_nerr (including Linux and FreeBSD) and use 
instead the workaround designed to somehow work on other 
platforms.

[...]

-- 
Maxim Dounin
http://nginx.org/