[PATCH] Core: reorder #ifdef in .h file to match order in .c file

Piotr Sikora piotrsikora at google.com
Wed Jul 13 17:29:04 UTC 2016


Hey Maxim,

> Current order matches one used in #if in the same .h file, and I
> don't think this order needs to be changed.

Hmm? Are we looking at the same files?

http://hg.nginx.org/nginx/file/tip/src/os/unix/ngx_setaffinity.h:

    #if (NGX_HAVE_SCHED_SETAFFINITY)
    ...
    #elif (NGX_HAVE_CPUSET_SETAFFINITY)
    ...
    #endif

http://hg.nginx.org/nginx/file/tip/src/os/unix/ngx_setaffinity.c:

    #if (NGX_HAVE_CPUSET_SETAFFINITY)
    ....
    #elif (NGX_HAVE_SCHED_SETAFFINITY)
    ....
    #endif

The order is different... And yes, I know that's nitpicking.

Best regards,
Piotr Sikora



More information about the nginx-devel mailing list