[PATCH] Headers filter: style

Maxim Dounin mdounin at mdounin.ru
Thu Jun 23 19:09:39 UTC 2016


On Thu, Jun 23, 2016 at 09:53:37AM -0700, Piotr Sikora wrote:

> Hey Maxim,
> > I would rather not.  The "hv" is used to refer to a particular
> > ngx_http_header_val_t, while "h" here is an array of elements.
> But "h" is used throughout the codebase for ngx_table_elt_t, which
> makes this particular case confusing.
> Also, "h" is used for ngx_table_elt_t regardless of whether it points
> to a particular item or an array, so your argument isn't consistent
> with the current style.

The "h" is used for variables of various types, including 
ngx_http_file_cache_header_t, ngx_str_t, ngx_keyval_t, 
ngx_table_elt_t, ngx_http_fastcgi_header_t, ngx_uint_t, uin32_t, 
and int.  It's just a convenient short name for a variable.

Maxim Dounin

More information about the nginx-devel mailing list