[PATCH] Upstream: avoid closing client conn when no response body needed

Justin Li jli.justinli at gmail.com
Wed Mar 9 17:11:27 UTC 2016


On Wed, Mar 9, 2016 at 10:22 AM, Maxim Dounin <mdounin at mdounin.ru> wrote:

> I don't see reasons why we need another flag (or the flag at all)
> to handle this case.  Just finalizing the request as in your last
> patch will handle things correctly.

You're right, it's not strictly necessary. My instinct was simply to avoid
adding further conditionals with special behaviour, which can be done by
using a common flag for both cases. I am totally OK with my last patch
though if you feel it's the better solution, now that I understand your
reasoning.

--
Justin Li
Developer @ Shopify
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.nginx.org/pipermail/nginx-devel/attachments/20160309/bdc588c3/attachment.html>


More information about the nginx-devel mailing list