Add support for buffering is scripted logs

Maxim Dounin mdounin at
Mon Aug 14 16:54:44 UTC 2017


On Mon, Aug 14, 2017 at 04:01:10PM +0000, Eran Kornblau wrote:

> Thanks Maxim, comments inline.
> > Hello!
> > 
> > On Mon, Aug 07, 2017 at 10:36:19AM +0000, Eran Kornblau wrote:
> > 
> > Just a quick note: for me, the whole feature looks questionable, and the implementation is far from being in a commitable state.
> > 
> Why questionable? you would probably agree that variables in the access log name can be useful in some cases,
> and you'd probably also agree that log compression is good (it saves a lot of IO for a negligible amount of CPU -
> we use it in all nginx servers we have). So why not allow both?

Obviously enough, every feature you can think of is useful in some 
cases.  The question is code complexity and other maintanance 
expenses compared to the usefulness of the particular feature.


> Thanks for the clarification, IMHO worth having it configurable (check_root=on/off), in my use case,
> the variables do not depend on anything a client can control (there will be vars generated by the strftime 
> module, and static strings from map), so the root check is simply irrelevant.
> Will be happy to submit a patch for that later if you agree, though less a priority for me than this patch.

No, thanks.

Maxim Dounin

More information about the nginx-devel mailing list