[nginx] Removed pthread mutex / conditional variables debug messages.

Maxim Dounin mdounin at mdounin.ru
Fri Jan 20 18:15:22 UTC 2017


details:   http://hg.nginx.org/nginx/rev/022ea0d17177
branches:  
changeset: 6875:022ea0d17177
user:      Maxim Dounin <mdounin at mdounin.ru>
date:      Fri Jan 20 21:14:18 2017 +0300
description:
Removed pthread mutex / conditional variables debug messages.

These messages doesn't seem to be needed in practice and only make
debugging logs harder to read.

diffstat:

 src/os/unix/ngx_thread_cond.c  |  11 -----------
 src/os/unix/ngx_thread_mutex.c |   9 ---------
 2 files changed, 0 insertions(+), 20 deletions(-)

diffs (89 lines):

diff --git a/src/os/unix/ngx_thread_cond.c b/src/os/unix/ngx_thread_cond.c
--- a/src/os/unix/ngx_thread_cond.c
+++ b/src/os/unix/ngx_thread_cond.c
@@ -16,8 +16,6 @@ ngx_thread_cond_create(ngx_thread_cond_t
 
     err = pthread_cond_init(cond, NULL);
     if (err == 0) {
-        ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0,
-                       "pthread_cond_init(%p)", cond);
         return NGX_OK;
     }
 
@@ -33,8 +31,6 @@ ngx_thread_cond_destroy(ngx_thread_cond_
 
     err = pthread_cond_destroy(cond);
     if (err == 0) {
-        ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0,
-                       "pthread_cond_destroy(%p)", cond);
         return NGX_OK;
     }
 
@@ -50,8 +46,6 @@ ngx_thread_cond_signal(ngx_thread_cond_t
 
     err = pthread_cond_signal(cond);
     if (err == 0) {
-        ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0,
-                       "pthread_cond_signal(%p)", cond);
         return NGX_OK;
     }
 
@@ -66,9 +60,6 @@ ngx_thread_cond_wait(ngx_thread_cond_t *
 {
     ngx_err_t  err;
 
-    ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0,
-                   "pthread_cond_wait(%p) enter", cond);
-
     err = pthread_cond_wait(cond, mtx);
 
 #if 0
@@ -76,8 +67,6 @@ ngx_thread_cond_wait(ngx_thread_cond_t *
 #endif
 
     if (err == 0) {
-        ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0,
-                       "pthread_cond_wait(%p) exit", cond);
         return NGX_OK;
     }
 
diff --git a/src/os/unix/ngx_thread_mutex.c b/src/os/unix/ngx_thread_mutex.c
--- a/src/os/unix/ngx_thread_mutex.c
+++ b/src/os/unix/ngx_thread_mutex.c
@@ -108,8 +108,6 @@ ngx_thread_mutex_create(ngx_thread_mutex
                       "pthread_mutexattr_destroy() failed");
     }
 
-    ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0,
-                   "pthread_mutex_init(%p)", mtx);
     return NGX_OK;
 }
 
@@ -126,8 +124,6 @@ ngx_thread_mutex_destroy(ngx_thread_mute
         return NGX_ERROR;
     }
 
-    ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0,
-                   "pthread_mutex_destroy(%p)", mtx);
     return NGX_OK;
 }
 
@@ -137,9 +133,6 @@ ngx_thread_mutex_lock(ngx_thread_mutex_t
 {
     ngx_err_t  err;
 
-    ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0,
-                   "pthread_mutex_lock(%p) enter", mtx);
-
     err = pthread_mutex_lock(mtx);
     if (err == 0) {
         return NGX_OK;
@@ -163,8 +156,6 @@ ngx_thread_mutex_unlock(ngx_thread_mutex
 #endif
 
     if (err == 0) {
-        ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0,
-                       "pthread_mutex_unlock(%p) exit", mtx);
         return NGX_OK;
     }
 


More information about the nginx-devel mailing list