[PATCH 1 of 4] HTTP/2: emit new frames only after applying all SETTINGS params

Valentin V. Bartenev vbart at nginx.com
Fri Jun 2 12:11:06 UTC 2017


On Thursday 01 June 2017 14:55:06 Piotr Sikora via nginx-devel wrote:
> Hey Valentin,
> 
> > The new initial window size can be lower than the previous one,
> > so the difference can be negative (that's why the delta parameter
> > of ngx_http_v2_adjust_windows() is ssize_t).
> 
> Oops, good catch, thanks!
> 
> Funnily enough, the original patch worked just fine (at least on
> systems where size of ssize_t was equal to size of ngx_uint_t), since
> the value would overflow and result in the same negative number when
> casted to ssize_t.
> 
> I updated patchset with suggested changes, please take a look.
> 

The whole patchset was committed.  Thank you.

  wbr, Valentin V. Bartenev



More information about the nginx-devel mailing list