[PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

Piotr Sikora piotrsikora at google.com
Sat Jun 17 20:48:33 UTC 2017

Hey Valentin,

> I've overlooked this while doing previous review, but it looks strange.
> Why do you use NGX_LOG_WARN for trailers headers?  It results in
> finalizing request with an error (in case of HTTP/2 it means RST_STREAM).
> For main headers the NGX_LOG_CRIT level is used.  It looks too serious,
> but the WARN level is too low.

Good catch, thanks!

This was left-over from the initial version, which skipped too long
trailers, instead of resetting stream.

Best regards,
Piotr Sikora

More information about the nginx-devel mailing list